Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinuxOne to nightly builds #445

Closed
mhdawson opened this Issue Jul 5, 2016 · 12 comments

Comments

Projects
None yet
2 participants
@mhdawson
Copy link
Member

mhdawson commented Jul 5, 2016

When master moved up to V8 v5.1 I added LinuxOne to the regular regression runs. The builds on LinuxOne have been green since then: https://ci.nodejs.org/job/node-test-commit-linuxone/

I'd like to add building/uploading binaries for LinuxOne to the nightly release jobs.

  • connect up release linxuxOne machine to the release CI
  • separate release job with linuxOne as target (copy of standard job)
  • validate binary runs other machines
  • add to standard release job
  • validate linuxOne included in nightlies and binaries are ok
  • validate linuxOne is in next stable and looks ok.

@mhdawson mhdawson self-assigned this Jul 5, 2016

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Aug 8, 2016

Ok ran test job here: https://ci-release.nodejs.org/job/iojs+release-s390/2/nodes=rhel72-s390x-release/console

and it built ok, but it looks like it needs additional keys/setup as a release machine to be able to publish the binaries.

@jbergstroem can you do the final configuration required for the release machine ?

Its https://ci-release.nodejs.org/computer/release-linuxonecc-rhel72-s390x-1/ and currently has the test key on it.

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Aug 8, 2016

I can do the last bits this week.

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Aug 15, 2016

@mhdawson I just tried logging into it with the test key but wasn't able to. Is it perhaps non-root?

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Aug 22, 2016

my bad I'd missed the step of adding the test key. Should be ok now.

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Aug 30, 2016

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Aug 31, 2016

Ran CITGM on binary from nightly on one of our internal RHEL 7.1 linuxOne machines and things look ok.

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Aug 31, 2016

Ok need to guard so that only builds on 6.x and higher for linuxOne.

This seems to do the trick:

if [[ $ARCH =~ s390x && ${NODE_VERSION%%.*} -lt "6" ]]; then
  echo "Not building $disttype on linuxOne slave as only supported on v.6x and later"
  exit 0
fi

@jbergstroem that look ok with you ? If so you ok with me adding that to the release build script and then adding linuxOne to the set of machines we build for ?

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Sep 6, 2016

@mhdawson LGTM; perhaps change message to (typo) ...as only supported on v6.x and later

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Sep 6, 2016

@mhdawson also, how about simplifying the expansion to ${NODE_VERSION:0:1}?

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Sep 6, 2016

Ok incorporate comments and added to the regular release CI job. Will check tomorrow to see how nightlies went.

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Sep 8, 2016

Did a check on the nightlies using CITGM on our local linuxOne RHEL71 boxes and I don't see anything unexpected that is not marked as flaky.

Once we have a stable that goes out, I'll sniff check that and then close this issue.

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Sep 29, 2016

Ok linuxOne was included in the 6.7.0 release and quick check that I could uncompress and get to prompt indicates its ok.

Closing.

@mhdawson mhdawson closed this Sep 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.