New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI jobs for readable-stream group #782

Open
gibfahn opened this Issue Jul 6, 2017 · 12 comments

Comments

Projects
None yet
5 participants
@gibfahn
Member

gibfahn commented Jul 6, 2017

Setting up initial jobs for readable-stream WG in #657

I'll create a streams-admins group following our process. That group will have edit access, streams will have run access.

@nodejs/build let me know if there are any objections.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn
Member

gibfahn commented Jul 6, 2017

@piccoloaiutante

This comment has been minimized.

Show comment
Hide comment
@piccoloaiutante

piccoloaiutante Jul 6, 2017

Member

excellent, go ahead 👍

Member

piccoloaiutante commented Jul 6, 2017

excellent, go ahead 👍

@gibfahn gibfahn self-assigned this Jul 6, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Jul 6, 2017

Member

+1

Member

mhdawson commented Jul 6, 2017

+1

@piccoloaiutante

This comment has been minimized.

Show comment
Hide comment
@piccoloaiutante

piccoloaiutante Jul 11, 2017

Member

@gibfahn let me know if you need any help on this

Member

piccoloaiutante commented Jul 11, 2017

@gibfahn let me know if you need any help on this

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jul 13, 2017

Member

Created the streams-admins team and added @mcollina and @calvinmetcalf (and made both maintainers).

I don't know enough about the WG to know who else will be active in maintaining Jenkins jobs. If anyone else should be added comment in this thread.

Member

gibfahn commented Jul 13, 2017

Created the streams-admins team and added @mcollina and @calvinmetcalf (and made both maintainers).

I don't know enough about the WG to know who else will be active in maintaining Jenkins jobs. If anyone else should be added comment in this thread.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jul 13, 2017

Member

Gave the two teams the appropriate access to readable-stream-continuous-integration, @mcollina please confirm you still have configure access.

Member

gibfahn commented Jul 13, 2017

Gave the two teams the appropriate access to readable-stream-continuous-integration, @mcollina please confirm you still have configure access.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jul 19, 2017

Member

It is all working. I removed some unneeded machines and the ones that suffer from #785.

Some things that I would like fixed:

  • some sort of aggregated test results, so that we know what failed across the environments, currently it reports no result
  • we need to be able to trigger this for all the Node.js versions at the same time, ideally from 0.8 to 8, and maybe even the latest nightly, can you help set that up as well?
  • can we post the status of the build to github as well?

Overall it works very well, I had to fix a configuration on our side. If you want to test, use the core-ci branch (nodejs/readable-stream#308).

Member

mcollina commented Jul 19, 2017

It is all working. I removed some unneeded machines and the ones that suffer from #785.

Some things that I would like fixed:

  • some sort of aggregated test results, so that we know what failed across the environments, currently it reports no result
  • we need to be able to trigger this for all the Node.js versions at the same time, ideally from 0.8 to 8, and maybe even the latest nightly, can you help set that up as well?
  • can we post the status of the build to github as well?

Overall it works very well, I had to fix a configuration on our side. If you want to test, use the core-ci branch (nodejs/readable-stream#308).

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jul 20, 2017

Member

Looks like @nodejs/streams didn't have build access (@nodejs/streams-admins did have edit access) because it's actually @nodejs/Streams with a capital S. Github lowercases everything, but the plugin doesn't. I've given both permutations (streams and Streams) access.


we need to be able to trigger this for all the Node.js versions at the same time, ideally from 0.8 to 8, and maybe even the latest nightly, can you help set that up as well?

What I've been doing for other projects is adding a pipeline that runs the job with a list of versions, current job is here: https://ci.nodejs.org/view/All/job/readable-stream-pipeline/. It doesn't do anything magical, it just splits the NODE_VERSIONs string by space, and spawns a job with each NODE_VERSION.

Member

gibfahn commented Jul 20, 2017

Looks like @nodejs/streams didn't have build access (@nodejs/streams-admins did have edit access) because it's actually @nodejs/Streams with a capital S. Github lowercases everything, but the plugin doesn't. I've given both permutations (streams and Streams) access.


we need to be able to trigger this for all the Node.js versions at the same time, ideally from 0.8 to 8, and maybe even the latest nightly, can you help set that up as well?

What I've been doing for other projects is adding a pipeline that runs the job with a list of versions, current job is here: https://ci.nodejs.org/view/All/job/readable-stream-pipeline/. It doesn't do anything magical, it just splits the NODE_VERSIONs string by space, and spawns a job with each NODE_VERSION.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jul 20, 2017

Member

BTW, if you want to add or remove platforms you modify the MACHINE label expression. If you want to run on a subset of platforms as a one off you modify the MACHINES parameter.

Member

gibfahn commented Jul 20, 2017

BTW, if you want to add or remove platforms you modify the MACHINE label expression. If you want to run on a subset of platforms as a one off you modify the MACHINES parameter.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jul 20, 2017

Member

How can we have some form of aggregated test results for each platform and some reporting for the pipeline?

My jenkins fu is extremely bad and out-of-date :(.

Member

mcollina commented Jul 20, 2017

How can we have some form of aggregated test results for each platform and some reporting for the pipeline?

My jenkins fu is extremely bad and out-of-date :(.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jul 20, 2017

Member

Sorry, I should have mentioned that I'm still working through your other requests!

Member

gibfahn commented Jul 20, 2017

Sorry, I should have mentioned that I'm still working through your other requests!

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jul 20, 2017

Member

thanks @gibfahn!

Member

mcollina commented Jul 20, 2017

thanks @gibfahn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment