Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect iojs.org to nodejs.org #1557

Closed
wants to merge 3 commits into from

Conversation

@fhemberger
Copy link
Contributor

commented Nov 1, 2018

Using full domain redirects, because the little amount of traffic still pointing
to iojs.org probably doesn't justify full url mapping redirects.

Ref: nodejs/iojs.org#432

Open issues:

  • Remove DNS entry for roadmap.iojs.org
    (linking to https://github.com/nodejs/roadmap/tree/gh-pages)
  • *.iojs.org also resolves to GitHub pages
  • What should happen with https://iojs.org/dist/?
    Drop it entirely? Integrate it somehow into https://nodejs.org/dist/?
  • What about tools like nvm or n, which still point to dist?
Redirect iojs.org to nodejs.org
Using full domain redirects, because the little amount of traffic still pointing
to iojs.org probably doesn't justify for full url mapping redirects.

Ref: nodejs/iojs.org#432
@fhemberger

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2018

/ping @nodejs/build

@fhemberger

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2018

@Trott Any thoughts about the open questions? Should we just ditch all iojs downloads completely (while we still keep stuff like Node.js 0.1.10 around)?
How will this affect 3rd-party-tools?

@refack

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

Remove DNS entry for roadmap.iojs.org
(linking to nodejs/roadmap@gh-pages)
*.iojs.org also resolves to GitHub pages

+1 for removing.

  • What should happen with https://iojs.org/dist/?
    Drop it entirely? Integrate it somehow into https://nodejs.org/dist/?
  • What about tools like nvm or n, which still point to dist?

If we integrate the two we could alias the old URI, so that tools wouldn't see a difference.

@refack

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

/CC @rvagg

@refack refack added the infra label Nov 11, 2018

@refack refack added this to untriaged in action items via automation Nov 11, 2018

@refack refack moved this from untriaged to todo in action items Nov 11, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

@Trott Any thoughts about the open questions? Should we just ditch all iojs downloads completely (while we still keep stuff like Node.js 0.1.10 around)?
How will this affect 3rd-party-tools?

/ping @nodejs/version-management

@ljharb
Copy link
Member

left a comment

For nvm to work properly, it needs nodejs.org/dist to not contain io.js versions, and iojs.org/dist to only contain io.js versions.

In other words, this PR will cause massive breakage for every nvm user as-is. Please do not merge it.

@Trott Trott dismissed their stale review Nov 11, 2018

dismissing until nvm issue is sorted....

@refack

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

For nvm to work properly, it needs nodejs.org/dist to not contain io.js versions, and iojs.org/dist to only contain io.js versions.

What I meant by integrating, is that we do just that, i.e. keep:

    location /dist {	
        alias /home/dist/iojs/release/;	
        autoindex on;	
        default_type text/plain;	
         location ~ \.json$ {	
            add_header access-control-allow-origin *;	
        }	
    }	
@ljharb

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

As long as all the same versions are accessible, and show up in distinct lists depending on the domain requested, everything will continue to work.

@fhemberger

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

Updated the PR to keep all location directives in place. PTAL.

@rvagg

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

I'm not sure the config matches the discussion here. Can we be more precise with what we're trying to achieve given the above discussion?

As far as the website is concerned, it's very simple and only has localisation directories plus an /images. Nothing deeper than that.

We also have locations that point to distributables, they are: /dist, /download, /api, and /docs.

My suggestion would be to redirect everything but those distributables, leaving them intact. Each of them lets you access specific versions and there's probably links out there on the web to them and people using weird versions that it might not be worth disrupting.

Use of assets in /images might also be a concern. We've tried really hard to not break historical links on nodejs.org since we started the Foundation, maybe that should extend here too?

Aside from the question of /images. If the redirect goes only in location /, the rest could stay intact.

FYI here's the DNS records for iojs.org, and also we actively use @iojs.org for emails.

iojs_dns

@fhemberger

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@rvagg Ok, so basically leave everything as it is (redirect http+www -> https, etc.) and only redirect / (as more specific location paths still have a higher rank).

I updated the PR accordingly, PTAL.

Removing the * CNAME record should also be fine to remove roadmap.iojs.org as well (added redirect in nginx config).

@rvagg

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

I think this looks good. Thankfully iojs.org isn't critical in the same way as nodejs.org so I'll be able to deploy and test it out. Our SSL cert expires this week so I'll need to sort that out too, either cloudflare or letsencrypt.

@rvagg

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

switched to letsencrypt on iojs.org

@rvagg

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

All done, landed in 7a7e700, I reworked some of the config to make nginx work and also activate ipv6 on some of the server stanzas (letsencrypt verifies via AAAA records when they exist).

Some letsencrypt config details for this added to #1552

@rvagg rvagg closed this Nov 21, 2018

@rvagg

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

and I removed the * -> gh-pages DNS record and put roadmap.iojs.org as a CNAME for iojs.org so the redirect works there too.

@refack refack moved this from todo to done in action items Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.