New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code And Learn at NodeFest 2017 #72

Closed
hiroppy opened this Issue Oct 18, 2017 · 32 comments

Comments

Projects
None yet
@hiroppy
Member

hiroppy commented Oct 18, 2017

Hi!

We will hold NodeFest which is the largest Node.js conference in Japan.
I’m one of the organizers this year.
The team members are @yosuke-furukawa, @watilde, myself and some other great nodeschool staff.

We would like to open code-and-learn-jp on NodeFest and support the contribution to nodejs/core.

Please feel free to suggest any contribution areas for the participants! @nodejs/collaborators
We will receive some PRs on 26th November.(http://nodefest.jp/2017/schedule.html)

/cc @yosuke-furukawa @watilde @nodejs/nodejs-ja

Thanks.

Mentors

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Oct 18, 2017

Member

cc @Trott @addaleax

Also, I will be there. Happy to help out with whatever needed.

Member

joyeecheung commented Oct 18, 2017

cc @Trott @addaleax

Also, I will be there. Happy to help out with whatever needed.

@ronkorving

This comment has been minimized.

Show comment
Hide comment
@ronkorving

ronkorving Oct 18, 2017

Of course I will be there 👍

ronkorving commented Oct 18, 2017

Of course I will be there 👍

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Oct 18, 2017

Member

Possible case in tests: nodejs/node#16243 (comment) + next comment: check else if by if replacements when a previous if contains return. Also check else eliminations on similar condition.

Member

vsemozhetbyt commented Oct 18, 2017

Possible case in tests: nodejs/node#16243 (comment) + next comment: check else if by if replacements when a previous if contains return. Also check else eliminations on similar condition.

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Oct 18, 2017

Member

@vsemozhetbyt Thank you for your information!

Member

hiroppy commented Oct 18, 2017

@vsemozhetbyt Thank you for your information!

@watilde

This comment has been minimized.

Show comment
Hide comment
@watilde

watilde Oct 18, 2017

Member

Note: Here is the last time we had - #58

Member

watilde commented Oct 18, 2017

Note: Here is the last time we had - #58

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 18, 2017

Member

This is awesome. Keep in mind that we're also running a small code-and-learn at NodeConf EU at the beginning of November so some of the tasks may adjust after that. We should likely coordinate a bit in advance to make sure we don't end up duplicating any effort! :-) (I totally wish I was able to get to Tokyo this year)

One possible set of tasks that I can suggest for new contributors who are bit more confident in their Node.js skills, would be converting tests to use the new ../common/countdown utility module.

For instance, if you take a look at: https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js, you'll see that there is a remaining counter (https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js#L19). The test then counts down remaining before closing the server. There are quite a large number of tests in our suite that perform similar actions in ways that are rather inconsistent. The ../common/countdown utility was designed to bring some consistency there.

The way the Countdown utility works is straightforward:

const common = require('../common');
const Countdown = require('../common/countdown');

// ...

const countdown = new Countdown(n, common.mustCall(() => {
  // do something here
}));

// Decrement the counter, the callback is called synchronously when
// countdown.dec is called n times.
countdown.dec();

I know that there are quite a few of the http2 tests that can benefit from this, along with a bunch of other http and https tests.

These tasks would be for folks who are a bit more comfortable with their Node.js skills.

Member

jasnell commented Oct 18, 2017

This is awesome. Keep in mind that we're also running a small code-and-learn at NodeConf EU at the beginning of November so some of the tasks may adjust after that. We should likely coordinate a bit in advance to make sure we don't end up duplicating any effort! :-) (I totally wish I was able to get to Tokyo this year)

One possible set of tasks that I can suggest for new contributors who are bit more confident in their Node.js skills, would be converting tests to use the new ../common/countdown utility module.

For instance, if you take a look at: https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js, you'll see that there is a remaining counter (https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js#L19). The test then counts down remaining before closing the server. There are quite a large number of tests in our suite that perform similar actions in ways that are rather inconsistent. The ../common/countdown utility was designed to bring some consistency there.

The way the Countdown utility works is straightforward:

const common = require('../common');
const Countdown = require('../common/countdown');

// ...

const countdown = new Countdown(n, common.mustCall(() => {
  // do something here
}));

// Decrement the counter, the callback is called synchronously when
// countdown.dec is called n times.
countdown.dec();

I know that there are quite a few of the http2 tests that can benefit from this, along with a bunch of other http and https tests.

These tasks would be for folks who are a bit more comfortable with their Node.js skills.

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Oct 18, 2017

Member

Another potential suggestion is replacing assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); It's another thing I would like to ideally introduce an eslint rule for (already have it written) but there are currently a ton of instances where we use the former.

I think that's pretty similar in difficulty to the change that was done at Node.js Interactive this year.

Member

apapirovski commented Oct 18, 2017

Another potential suggestion is replacing assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); It's another thing I would like to ideally introduce an eslint rule for (already have it written) but there are currently a ton of instances where we use the former.

I think that's pretty similar in difficulty to the change that was done at Node.js Interactive this year.

@AndreasMadsen

This comment has been minimized.

Show comment
Hide comment
@AndreasMadsen

AndreasMadsen Oct 18, 2017

Member

A simple thing is removing the redundant + from +conf.n in the benchmarks. If the values are integers in the bench(main, conf) object they will be integers in the main(conf) object too.

example: https://github.com/nodejs/node/blob/master/benchmark/assert/deepequal-object.js#L30L31

Member

AndreasMadsen commented Oct 18, 2017

A simple thing is removing the redundant + from +conf.n in the benchmarks. If the values are integers in the bench(main, conf) object they will be integers in the main(conf) object too.

example: https://github.com/nodejs/node/blob/master/benchmark/assert/deepequal-object.js#L30L31

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Oct 19, 2017

Member

@jasnell @apapirovski @AndreasMadsen Thanks.🙌 I try to summarize that information in Gist.
You should come to Nodefest2017!!

Member

hiroppy commented Oct 19, 2017

@jasnell @apapirovski @AndreasMadsen Thanks.🙌 I try to summarize that information in Gist.
You should come to Nodefest2017!!

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Oct 19, 2017

Member
Member

MylesBorins commented Oct 19, 2017

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Oct 19, 2017

Member

@abouthiroppy For my suggestion above, I created a gist with an eslint rule that will let you find all instances of assert.throws(fn, common.expectsError(err));.

Member

apapirovski commented Oct 19, 2017

@abouthiroppy For my suggestion above, I created a gist with an eslint rule that will let you find all instances of assert.throws(fn, common.expectsError(err));.

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Oct 20, 2017

Member

@MylesBorins Thanks!! yep, but I don't know the values session of node interactive. Would you give me this information?

@apapirovski wow, thank you so much 🙇 I'll use it!

Member

hiroppy commented Oct 20, 2017

@MylesBorins Thanks!! yep, but I don't know the values session of node interactive. Would you give me this information?

@apapirovski wow, thank you so much 🙇 I'll use it!

@seishun

This comment has been minimized.

Show comment
Hide comment
@seishun

seishun Oct 23, 2017

Member

I'm on the fence about attending (concerned about the cost mostly).

Member

seishun commented Oct 23, 2017

I'm on the fence about attending (concerned about the cost mostly).

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Nov 11, 2017

Member

Also, I will be there. Happy to help out with whatever needed.

Member

fhinkel commented Nov 11, 2017

Also, I will be there. Happy to help out with whatever needed.

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Nov 18, 2017

Member

Sorry for my late reply.

@seishun I think that Node.js Foundation will help with the cost.
@fhinkel Thanks!

Member

hiroppy commented Nov 18, 2017

Sorry for my late reply.

@seishun I think that Node.js Foundation will help with the cost.
@fhinkel Thanks!

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 18, 2017

Member

@seishun I think that Node.js Foundation will help with the cost.

I don't think the foundation typically sends Collaborators to an event simply because it's a Node.js event. It's usually a Collaborator Summit. There have been some exceptions though, like sending particular people to a TC-39 meeting one time.

That said, there's absolutely nothing stopping any Collaborator from requesting funds from the TSC for something by opening an issue in the TSC repository.

Member

Trott commented Nov 18, 2017

@seishun I think that Node.js Foundation will help with the cost.

I don't think the foundation typically sends Collaborators to an event simply because it's a Node.js event. It's usually a Collaborator Summit. There have been some exceptions though, like sending particular people to a TC-39 meeting one time.

That said, there's absolutely nothing stopping any Collaborator from requesting funds from the TSC for something by opening an issue in the TSC repository.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 20, 2017

Member

Have we prepared a list of changes for participants to implement?

How many people are we expecting?

Member

MylesBorins commented Nov 20, 2017

Have we prepared a list of changes for participants to implement?

How many people are we expecting?

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 20, 2017

Member

I guess 30 - 50 people.

Member

yosuke-furukawa commented Nov 20, 2017

I guess 30 - 50 people.

@yosuke-furukawa

This comment has been minimized.

Show comment
Hide comment
@yosuke-furukawa

yosuke-furukawa Nov 20, 2017

Member

Have we prepared a list of changes for participants to implement?
Not yet !! I will create the list asap...

Member

yosuke-furukawa commented Nov 20, 2017

Have we prepared a list of changes for participants to implement?
Not yet !! I will create the list asap...

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 20, 2017

Member
Member

MylesBorins commented Nov 20, 2017

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Nov 20, 2017

Member

a list of changes for participants 

TODO file line note status
Fix typo doc/api/util.md 695 occuring
Add link of ECMAScript 2015 doc/api/buffer.md 2740
Add link to dns.resolve() doc/api/dns.md 632
Use common.hasIntl instead of typeof Intl test/parallel/test-intl-v8BreakIterator.js 6
replace Function with Arrow Function doc/api/util.md 442, 552, 567, 568
test-writeint.js
test-querystring.js
test-assert.js
test-http.js 109, 118, 127, 128
test-http-pause.js
doc/api/vm.md 477
test-timers.js
test-whatwg-url-searchparams-getall.js
test-writeuint.js
test-child-process-send-cb.js
test-zerolengthbufferbug.js
test-domain-top-level-error-handler-clears-stack.js
use === and ' test-whatwg-url-setters.js 43
add ; test-whatwg-url-setters.js 35, 81
make use of const or let test-whatwg-url-setters.js 41 - 49
many files.... find ./ -type f -print | xargs grep var
fix comments test-assert.js 617, 5292
make use of Number.isNaN test-process-emit.js 22
test-readdouble.js
test-readfloat.js
test-writedouble.js
test-writefloat.js

please modify freely!

Member

hiroppy commented Nov 20, 2017

a list of changes for participants 

TODO file line note status
Fix typo doc/api/util.md 695 occuring
Add link of ECMAScript 2015 doc/api/buffer.md 2740
Add link to dns.resolve() doc/api/dns.md 632
Use common.hasIntl instead of typeof Intl test/parallel/test-intl-v8BreakIterator.js 6
replace Function with Arrow Function doc/api/util.md 442, 552, 567, 568
test-writeint.js
test-querystring.js
test-assert.js
test-http.js 109, 118, 127, 128
test-http-pause.js
doc/api/vm.md 477
test-timers.js
test-whatwg-url-searchparams-getall.js
test-writeuint.js
test-child-process-send-cb.js
test-zerolengthbufferbug.js
test-domain-top-level-error-handler-clears-stack.js
use === and ' test-whatwg-url-setters.js 43
add ; test-whatwg-url-setters.js 35, 81
make use of const or let test-whatwg-url-setters.js 41 - 49
many files.... find ./ -type f -print | xargs grep var
fix comments test-assert.js 617, 5292
make use of Number.isNaN test-process-emit.js 22
test-readdouble.js
test-readfloat.js
test-writedouble.js
test-writefloat.js

please modify freely!

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 21, 2017

Member

We can try replacing all the google.com or this.hostname.is.invalid etc. references in test/parallel with configurable variables defined in internet.addresses

Member

joyeecheung commented Nov 21, 2017

We can try replacing all the google.com or this.hostname.is.invalid etc. references in test/parallel with configurable variables defined in internet.addresses

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 21, 2017

Member

Also there are a few tasks that could be more advanced: find the tests in test/parallel that are making actual dns calls, use mocked lookup functions or put those in test/internet. Searching for DNS error codes like EAI_AGAIN or ENOTFOUND in test/parallel would yield a bunch of tests that try to work around this even though they are not supposed to work around that.

Member

joyeecheung commented Nov 21, 2017

Also there are a few tasks that could be more advanced: find the tests in test/parallel that are making actual dns calls, use mocked lookup functions or put those in test/internet. Searching for DNS error codes like EAI_AGAIN or ENOTFOUND in test/parallel would yield a bunch of tests that try to work around this even though they are not supposed to work around that.

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung
Member

joyeecheung commented Nov 21, 2017

@watilde

This comment has been minimized.

Show comment
Hide comment
@watilde

watilde Nov 23, 2017

Member

I've added some to #72 (comment).

Member

watilde commented Nov 23, 2017

I've added some to #72 (comment).

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 26, 2017

Member
TODO file line note status
Replace e->ToObject(env->isolate()) with e->ToObject(env->context()).ToLocalChecked() src/node.cc line 592
Replace e->ToObject(env->isolate()) with e->ToObject(env->context()).ToLocalChecked() src/node.cc line 754
Replace er->ToObject(env->isolate()) with er->ToObject(env->context()).ToLocalChecked() src/node.cc line 1485
Replace args[0]->ToObject(env->isolate()) with args[0]->ToObject(env->context()).ToLocalChecked() src/node.cc line 2304
Replace args[1]->ToString(env->isolate()) with args[1]->ToString(env->context()).ToLocalChecked() src/node.cc line 2322
Replace module->Get(exports_string)->ToObject(env->isolate()) with module->Get(exports_string)->ToObject(env->context()).ToLocalChecked() src/node.cc line 2367
Replace process_object->Get(exit_code)->ToInteger(env->isolate()) with process_object->Get(exit_code)->ToInteger(env->context()).ToLocalChecked() src/node.cc line 4340
Replace args[1]->ToString(env->isolate()) with args[1]->ToString(env->context()).ToLocalChecked() src/node_buffer.cc line 609
Replace args[0]->ToString(env->isolate()) with args[0]->ToString(env->context()).ToLocalChecked() src/node_buffer.cc line 680
Replace args[0]->ToString(env->isolate()) with args[0]->ToString(env->context()).ToLocalChecked() src/node_contextify.cc line 624
Replace args[1]->ToObject(env->isolate()) with args[1]->ToObject(env->context()).ToLocalChecked() src/node_file.cc line 1222
Replace e->ToObject(env->isolate()) with e->ToObject(env->context()).ToLocalChecked() src/node_http_parser.cc line 469
Replace args[1]->ToObject(env->isolate()) with args[1]->ToObject(env->context()).ToLocalChecked() src/node_zlib.cc line 181
Replace args[4]->ToObject(env->isolate()) with args[4]->ToObject(env->context()).ToLocalChecked() src/node_zlib.cc line 190
Replace args[0]->ToObject(env->isolate()) with args[0]->ToObject(env->context()).ToLocalChecked() src/process_wrap.cc line 146
Replace chunk->ToString(env->isolate()) with chunk->ToString(env->context()).ToLocalChecked() src/stream_base.cc line 130
Replace chunk->ToString(env->isolate()) with chunk->ToString(env->context()).ToLocalChecked() src/stream_base.cc line 182

This is generated with a script but should be a safe list

Member

joyeecheung commented Nov 26, 2017

TODO file line note status
Replace e->ToObject(env->isolate()) with e->ToObject(env->context()).ToLocalChecked() src/node.cc line 592
Replace e->ToObject(env->isolate()) with e->ToObject(env->context()).ToLocalChecked() src/node.cc line 754
Replace er->ToObject(env->isolate()) with er->ToObject(env->context()).ToLocalChecked() src/node.cc line 1485
Replace args[0]->ToObject(env->isolate()) with args[0]->ToObject(env->context()).ToLocalChecked() src/node.cc line 2304
Replace args[1]->ToString(env->isolate()) with args[1]->ToString(env->context()).ToLocalChecked() src/node.cc line 2322
Replace module->Get(exports_string)->ToObject(env->isolate()) with module->Get(exports_string)->ToObject(env->context()).ToLocalChecked() src/node.cc line 2367
Replace process_object->Get(exit_code)->ToInteger(env->isolate()) with process_object->Get(exit_code)->ToInteger(env->context()).ToLocalChecked() src/node.cc line 4340
Replace args[1]->ToString(env->isolate()) with args[1]->ToString(env->context()).ToLocalChecked() src/node_buffer.cc line 609
Replace args[0]->ToString(env->isolate()) with args[0]->ToString(env->context()).ToLocalChecked() src/node_buffer.cc line 680
Replace args[0]->ToString(env->isolate()) with args[0]->ToString(env->context()).ToLocalChecked() src/node_contextify.cc line 624
Replace args[1]->ToObject(env->isolate()) with args[1]->ToObject(env->context()).ToLocalChecked() src/node_file.cc line 1222
Replace e->ToObject(env->isolate()) with e->ToObject(env->context()).ToLocalChecked() src/node_http_parser.cc line 469
Replace args[1]->ToObject(env->isolate()) with args[1]->ToObject(env->context()).ToLocalChecked() src/node_zlib.cc line 181
Replace args[4]->ToObject(env->isolate()) with args[4]->ToObject(env->context()).ToLocalChecked() src/node_zlib.cc line 190
Replace args[0]->ToObject(env->isolate()) with args[0]->ToObject(env->context()).ToLocalChecked() src/process_wrap.cc line 146
Replace chunk->ToString(env->isolate()) with chunk->ToString(env->context()).ToLocalChecked() src/stream_base.cc line 130
Replace chunk->ToString(env->isolate()) with chunk->ToString(env->context()).ToLocalChecked() src/stream_base.cc line 182

This is generated with a script but should be a safe list

@joyeecheung joyeecheung reopened this Nov 26, 2017

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 26, 2017

Member

Sorry, accidentally pressed the wrong button

Member

joyeecheung commented Nov 26, 2017

Sorry, accidentally pressed the wrong button

@smatsu-hl smatsu-hl referenced this issue Nov 26, 2017

Closed

doc: Add link of ECMAScript 2015 #17317

2 of 2 tasks complete

@koooge koooge referenced this issue Nov 26, 2017

Closed

test: use allow function #17318

3 of 3 tasks complete
@kt3k

This comment has been minimized.

Show comment
Hide comment
@kt3k

kt3k Nov 26, 2017

It was very fun! thank you!

kt3k commented Nov 26, 2017

It was very fun! thank you!

@fossamagna fossamagna referenced this issue Nov 26, 2017

Closed

test: use Number.isNaN() #17319

3 of 3 tasks complete
@hiroppy

This comment has been minimized.

Show comment
Hide comment
@hiroppy

hiroppy Nov 26, 2017

Member

@yosuke-furukawa @joyeecheung @MylesBorins Thank you for your help! I was really happy :)

Member

hiroppy commented Nov 26, 2017

@yosuke-furukawa @joyeecheung @MylesBorins Thank you for your help! I was really happy :)

@hiroppy hiroppy closed this Nov 26, 2017

Leko added a commit to Leko/node that referenced this issue Nov 27, 2017

test: replace function with arrow function
Among the list of [Code and Learn](nodejs/code-and-learn#72 (comment)), I solved the unfinished task of replacing function with arrow function

@Leko Leko referenced this issue Nov 27, 2017

Closed

test: replace function with arrow function #17345

3 of 3 tasks complete

vsemozhetbyt added a commit to nodejs/node that referenced this issue Nov 29, 2017

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: #17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

@mithunsasidharan mithunsasidharan referenced this issue Dec 8, 2017

Closed

test : lint and few minor fixes #17549

3 of 3 tasks complete

MylesBorins added a commit to nodejs/node that referenced this issue Dec 12, 2017

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: #17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this issue Dec 12, 2017

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: #17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

gibfahn added a commit to nodejs/node that referenced this issue Dec 19, 2017

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: #17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

gibfahn added a commit to nodejs/node that referenced this issue Dec 19, 2017

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: #17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

gibfahn added a commit to nodejs/node that referenced this issue Dec 20, 2017

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: #17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

sreepurnajasti added a commit to sreepurnajasti/node that referenced this issue Dec 21, 2017

sreepurnajasti added a commit to sreepurnajasti/node that referenced this issue Jan 4, 2018

sreepurnajasti added a commit to sreepurnajasti/node that referenced this issue Jan 5, 2018

BridgeAR added a commit to BridgeAR/node that referenced this issue Jan 19, 2018

benchmark: remove redundant +
PR-URL: nodejs#17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

evanlucas added a commit to nodejs/node that referenced this issue Jan 30, 2018

benchmark: remove redundant +
PR-URL: #17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

evanlucas added a commit to nodejs/node that referenced this issue Jan 30, 2018

benchmark: remove redundant +
PR-URL: #17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

msoechting added a commit to hpicgs/node that referenced this issue Feb 5, 2018

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: nodejs#17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

msoechting added a commit to hpicgs/node that referenced this issue Feb 5, 2018

benchmark: remove redundant +
PR-URL: nodejs#17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

msoechting added a commit to hpicgs/node that referenced this issue Feb 7, 2018

test: replace function with arrow function
1. Among the list of Code and Learn,
I solved the unfinished task of replacing function with arrow function:
nodejs/code-and-learn#72 (comment)

2. Replace arrow function with shorter property syntax
Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.

3. Replace this with null
makeBlock does not need `this`.
update `this` with `null` to clarify the intent.

PR-URL: nodejs#17345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

msoechting added a commit to hpicgs/node that referenced this issue Feb 7, 2018

benchmark: remove redundant +
PR-URL: nodejs#17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this issue Feb 27, 2018

benchmark: remove redundant +
PR-URL: #17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018

benchmark: remove redundant +
PR-URL: nodejs#17803
Refs: nodejs/code-and-learn#72
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment