Skip to content

Conversation

@flakey5
Copy link
Member

@flakey5 flakey5 commented Nov 28, 2025

Re nodejs/node#57343 (comment)

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

Re nodejs/node#57343 (comment)

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5 flakey5 requested a review from a team as a code owner November 28, 2025 22:20
@vercel
Copy link

vercel bot commented Nov 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Nov 28, 2025 11:37pm

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.60%. Comparing base (a97df05) to head (bcb615e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../legacy-json/utils/__tests__/buildSection.test.mjs 97.10% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   74.10%   74.60%   +0.50%     
==========================================
  Files         111      112       +1     
  Lines       10562    10700     +138     
  Branches      701      722      +21     
==========================================
+ Hits         7827     7983     +156     
+ Misses       2732     2714      -18     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd
Copy link
Member

ovflowd commented Nov 28, 2025

@flakey5 could you add unit tests?

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! thanks for quickly going through it!!

@ovflowd ovflowd merged commit 9285e74 into main Nov 28, 2025
19 checks passed
@ovflowd ovflowd deleted the flakey5/20251128/fix branch November 28, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants