Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp Refactoring Ensuring avoiding duplicate package cache #58

Closed
wants to merge 1 commit into
base: modules-lkgr
from

Conversation

Projects
None yet
4 participants
@guybedford
Copy link
Contributor

guybedford commented Mar 10, 2019

This brings through the refactorings from #57 that avoid cache duplication and should improve performance, described in detail there, while retaining the current behaviour of having the --type flag only apply to the entry point file and not any other files in the entry point scope.

@guybedford guybedford force-pushed the guybedford:cppformat branch 2 times, most recently from e59148d to b6baba4 Mar 10, 2019

@ljharb

ljharb approved these changes Mar 10, 2019

Copy link
Contributor

ljharb left a comment

I can’t review the cpp, but I’m trusting that this PR doesn’t change observable behavior and that the docs are improved :-)

@MylesBorins MylesBorins force-pushed the nodejs:modules-lkgr branch from bec588f to ea59221 Mar 11, 2019

@nodejs-ci nodejs-ci force-pushed the nodejs:modules-lkgr branch from ea59221 to c6d1b01 Mar 12, 2019

@nodejs-ci nodejs-ci force-pushed the nodejs:modules-lkgr branch from c6d1b01 to b4abd3a Mar 13, 2019

@guybedford guybedford force-pushed the guybedford:cppformat branch 2 times, most recently from 2a3f448 to 4d25173 Mar 13, 2019

@guybedford guybedford force-pushed the guybedford:cppformat branch from 4d25173 to 41182b8 Mar 13, 2019

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Mar 13, 2019

landed in c894000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.