Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: do not allow ESM flags without --experimental-modules #62

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@targos
Copy link
Member

targos commented Mar 14, 2019

This change makes sure that flags related to --experimental-modules cannot be passed without --experimental-modules. It also validates the two possible values for --es-module-specifier-resolution

@MylesBorins

This comment has been minimized.

@ljharb

ljharb approved these changes Mar 14, 2019

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Mar 14, 2019

failure is unrelated. Will land in 2 hours if there are no objections... necessary for upstreaming

@MylesBorins MylesBorins merged commit af99410 into modules-lkgr Mar 15, 2019

@ljharb ljharb deleted the fix-flags branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.