This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
Add languages support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohmigosh. This is so rad! Thanks @xcatliu Verified as good on my end, but if you'd like to wait to have another person check the translation 🎉 |
|
@nodejs/nodejs-cn Can somebody help me check the translation? Thanks! |
|
I can review within this week! |
|
All good 👍! LGTM |
|
Hi, @coderhaoxin |
|
LGTM |
|
@laosb @coderhaoxin Thanks for your reviewing! |
|
Glad to see! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hackygolucky ,
I finished the localization of Node Live Beijing, then added some features. Now it's easy to add another language to this site. Please help to review the change of build script when you have time.
@JacksonTian @XadillaX Please help to review the translation.
Solved nodejs/Intl#31