-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 source list always fails w/ error: USAGE: v8 source list #138
Comments
That seems fine, just verify that FWIW, the command seems broken on my machine, even with that change. I'll try to take a deeper look when I have a chance. |
I ran into this issue too. My workaround was the following given this frame:
Sometimes it errors out with this |
same issue here, so far i haven't been able to print any source, even with the workarounds mentioned |
@robertkowalski The issue you're running into seems like it might be a different problem. Would you mind opening a separate issue that provide as much detail as possible, such as the node version you're using, and detailed repro steps? |
`v8 source list` was expecting an undocumented flag -l, which is the first line the command will output from source code. This commit makes that flag optional, documents the flag, improves the help message for this command and adds tests for it. Fixes: nodejs#138
I upgraded llnode install 1.6.2 on both Ubuntu 16.04 and FreeBSD 12 and ran through the tutorial here
https://developer.ibm.com/node/2016/08/15/exploring-node-js-core-dumps-using-the-llnode-plugin-for-lldb/
When a frame is selected (e.g.
frame select 6
) and the source viewed withv8 source list
the response is alwayserror: USAGE: v8 source list
@cjihrig This seems to have been introduced in 1.6.0
1d43035#diff-81649c6431efceafdaca2ec7afb55f38R187
When the
*cmd == nullptr
part of the conditional is removed the source is printed as expected.I can PR the removal but would appreciate a second pair of eyes to confirm it won't impact the original seg faults fix.
Thanks
The text was updated successfully, but these errors were encountered: