Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release Plan #400

Closed
MylesBorins opened this issue Oct 11, 2019 · 7 comments

Comments

@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Oct 11, 2019

As per #399 (comment) it seems like folks are not comfortable with unflagging modules on LTS without it having lived in a current release for sometime. So here is a suggestion for an alternative path forward.

  • Land all changes including aside from unflagging on v13.x ASAP
  • Bring #371 to the TSC meeting next Wednesday specifically with the ask if we should delay the removal of the flag until we have a solution to "dual mode packages"
    • If the TSC is ok with unflagging we land the removal of the flag on 13.x and ship unflagged esm in 13.0.0
    • If the TSC would like us to spend more time on the problem before we unflag we don't unflag on 13.x and spend some time dedicated to that problem space
  • Backport all changes to 12.x aside from the flag removal
  • Assuming there is not major ecosystem push back we aim to remove the flag in the 1st or 2nd Semver Minor of 12.x LTS (likely in December or March)

Thoughts?

@jkrems

This comment has been minimized.

Copy link
Contributor

@jkrems jkrems commented Oct 11, 2019

I think that sounds reasonable.

@targos

This comment has been minimized.

Copy link
Member

@targos targos commented Oct 11, 2019

I think so too

@GeoffreyBooth

This comment has been minimized.

Copy link
Contributor

@GeoffreyBooth GeoffreyBooth commented Oct 11, 2019

Agreed, and I think once we settle exactly what the plan is (get a response from the TSC etc.) I think we should announce the expected release version and date, perhaps in another Medium post. That would invite the public to give --experimental-modules one last thorough test before we unflag, to hopefully shake out as many bugs as possible before unflagging.

@mcollina

This comment has been minimized.

Copy link
Member

@mcollina mcollina commented Oct 11, 2019

+1 to the plan. I would personally recommend to drop the flag in v13.

@kirkouimet

This comment has been minimized.

Copy link

@kirkouimet kirkouimet commented Oct 23, 2019

@MylesBorins - As of Node 13.0.0 the flag is still required, correct?

@MylesBorins

This comment has been minimized.

Copy link
Member Author

@MylesBorins MylesBorins commented Oct 23, 2019

@GeoffreyBooth

This comment has been minimized.

Copy link
Contributor

@GeoffreyBooth GeoffreyBooth commented Oct 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.