Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move loaders to phase 3 #287

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Projects
None yet
4 participants
@guybedford
Copy link
Contributor

guybedford commented Mar 4, 2019

This PR moves the new loaders work to Phase 3.

This is assuming nodejs/ecmascript-modules#47 to include a solution in the mean time.

I've worked with @bmeck to understand where the current implementation is, and did consider driving this work over the next week to get something together, but we should probably try to be sensible about the design process here.

@MylesBorins
Copy link
Member

MylesBorins left a comment

LGTM

@ljharb

ljharb approved these changes Mar 4, 2019

@MylesBorins MylesBorins referenced this pull request Mar 5, 2019

Open

Steps required to upstream implementation #286

11 of 12 tasks complete

@GeoffreyBooth GeoffreyBooth merged commit 656b2d1 into master Mar 6, 2019

@GeoffreyBooth GeoffreyBooth deleted the loaders-phase3 branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.