Join GitHub today
add support for node master #831
This PR allows to use NAN with current Node on master and should fix several fails in CITGM which use NAN.
Not sure if this should be really included in NAN at this time as Node plans to do further updates of V8 till v12 is released (see nodejs/node#25060 (comment)).
There is still a self deprecation warning in v8 left but I think this should be addressed inside v8 or in the patched v8 variant included in node.
Rebased to 2.12.1.
I'm fine with waiting.
I think there are quite some people out there which would be happy with a nan release working with node master. But it's up to them to convince you to take this maintenance burden
Maybe someone (or even myself) finds some time to port nan to use napi. This would help a lot in future but not sure if it is that easy. It would be for sure a good test for napi completeness.
Maintenance burden indeed. Unfortunately, I do not have time to follow a volatile moving target with actual releases, since every release comes with a risk of something unintentionally breaking. However, merging to master would not hurt. Whoever wants to be on the bleeding edge can easily do so then.
I had originally thought of doing precisely that, but shelved the plans due to lack of time and motivation. A common feature set could likely be mapped onto NAPI, but AFAIK there are be some (rare) V8-specific features which arguably do not fit in napi, e.g. the garbage collection API.