Implement wrapper for EVP_AEAD interface #15
Merged
+540
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Oct 30, 2025
jasnell
reviewed
Nov 4, 2025
jasnell
reviewed
Nov 4, 2025
jasnell
reviewed
Nov 4, 2025
jasnell
reviewed
Nov 4, 2025
jasnell
approved these changes
Nov 4, 2025
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
Couple of nits... otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements wrappers for BoringSSL's
EVP_AEADinterface which is used to access AEAD (authenticated encryption with associated data) modes likechacha20-poly1305andaes-256-gcm. You can't use theEVP_CIPHERinterface like you could in OpenSSL, you have to useEVP_AEAD. UnlikeEVP_CIPHER,EVP_AEADdoes not provide much support for dynamically getting a cipher from a string, nor for getting info about a chosen cipher. I had to provide this in ncrypto itself. This PR also adds a couple tests.