Skip to content

Conversation

@matthargett
Copy link
Contributor

Silence a legitimate vfptr sanitizer warning that is on by default in Android NDK 29's clang. Stripping RTTI from a vfptr is usually a no-no for debugging and field-supportability reasons, but it's intrinsic to how ObjectWrap works right now.

This was found whilst porting BabylonNative (which implements NAPI for add-ons) to Android XR, and was integrated (and tested) there as a local patch:
https://github.com/BabylonJS/JsRuntimeHost/pull/118/files#diff-a9d53b78150c809d9bf63a90260b4f823918bc6e6d9c3e02eb68d855bf9deda1R4499

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.50%. Comparing base (60d439e) to head (9affd1c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
napi-inl.h 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
+ Coverage   63.48%   63.50%   +0.01%     
==========================================
  Files           3        3              
  Lines        2046     2047       +1     
  Branches      728      728              
==========================================
+ Hits         1299     1300       +1     
  Misses        162      162              
  Partials      585      585              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas merged commit 46673f4 into nodejs:main Dec 5, 2025
60 checks passed
@github-project-automation github-project-automation bot moved this from Need Triage to Done in Node-API Team Project Dec 5, 2025
@github-actions github-actions bot mentioned this pull request Dec 5, 2025
@matthargett matthargett deleted the sanitizer-fix branch December 5, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants