From 75c30c1f249eaabe6fc3d2d500239688e8680872 Mon Sep 17 00:00:00 2001 From: avivkeller Date: Fri, 7 Aug 2026 20:02:03 -0400 Subject: [PATCH] chore: remove fast-tracking from code-and-learn Signed-off-by: avivkeller --- lib/pr_checker.js | 6 +--- test/fixtures/code_and_learn_pr.json | 23 -------------- test/unit/pr_checker.test.js | 46 ---------------------------- 3 files changed, 1 insertion(+), 74 deletions(-) delete mode 100644 test/fixtures/code_and_learn_pr.json diff --git a/lib/pr_checker.js b/lib/pr_checker.js index 99d9ea44..c4058f12 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -194,15 +194,11 @@ export default class PRChecker { const labels = pr.labels.nodes.map((l) => l.name); let isFastTracked = labels.includes('fast-track'); - const isCodeAndLearn = labels.includes('code-and-learn'); const isSemverMajor = labels.includes('semver-major'); // NOTE: a semver-major PR with fast-track should have either one of // these labels removed because that doesn't make sense if (isFastTracked) { cli.info('This PR is being fast-tracked'); - } else if (isCodeAndLearn) { - cli.info('This PR is being fast-tracked because ' + - 'it is from a Code and Learn event'); } if (approved.length === 0 || requestedChanges.length > 0) { @@ -273,7 +269,7 @@ export default class PRChecker { }; if (approved.length >= 2) { - if (isFastTracked || isCodeAndLearn) { + if (isFastTracked) { return true; } if (timeLeftMulti < 0) { diff --git a/test/fixtures/code_and_learn_pr.json b/test/fixtures/code_and_learn_pr.json deleted file mode 100644 index da26e2fb..00000000 --- a/test/fixtures/code_and_learn_pr.json +++ /dev/null @@ -1,23 +0,0 @@ -{ - "createdAt": "2017-10-24T11:13:43Z", - "authorAssociation": "FIRST_TIMER", - "author": { - "login": "pr_author", - "email": "pr_author@example.com", - "name": "Their Github Account email" - }, - "url": "https://github.com/nodejs/node/pull/16438", - "bodyHTML": "

Awesome changes

", - "bodyText": "Awesome changes", - "labels": { - "nodes": [ - { - "name": "test", - "name": "code-and-learn" - } - ] - }, - "title": "test: awesome changes", - "baseRefName": "main", - "headRefName": "awesome-changes" -} diff --git a/test/unit/pr_checker.test.js b/test/unit/pr_checker.test.js index 22fed0b1..109fc2cf 100644 --- a/test/unit/pr_checker.test.js +++ b/test/unit/pr_checker.test.js @@ -562,52 +562,6 @@ describe('PRChecker', () => { cli.assertCalledWith(expectedLogs); }); - it('should fast track code-and-learn PRs', () => { - const cli = new TestCLI(); - - const expectedLogs = { - ok: - [['Approvals: 4'], - ['- Foo User (@foo): https://github.com/nodejs/node/pull/16438#pullrequestreview-71480624'], - ['- Quux User (@Quux): LGTM'], - ['- Baz User (@Baz): https://github.com/nodejs/node/pull/16438#pullrequestreview-71488236'], - ['- Bar User (@bar) (TSC): lgtm']], - info: - [['This PR was created on Fri, 30 Nov 2018 17:50:44 GMT'], - ['This PR is being fast-tracked because ' + - 'it is from a Code and Learn event'] - ] - }; - - const pr = Object.assign({}, firstTimerPR, { - createdAt: LT_48H, - labels: { - nodes: [ - { name: 'code-and-learn' } - ] - } - }); - - const data = { - pr, - reviewers: allGreenReviewers, - comments: commentsWithCI, - reviews: approvingReviews, - commits: [], - collaborators, - authorIsNew: () => true, - getThread() { - return PRData.prototype.getThread.call(this); - } - }; - const checker = new PRChecker(cli, data, {}, argv); - - cli.clearCalls(); - const status = checker.checkReviewsAndWait(new Date(NOW)); - assert(status); - cli.assertCalledWith(expectedLogs); - }); - it('should check the last fast-track request comment', () => { const cli = new TestCLI();