From b03cd8c9fa5de55bca2fe774ca5edd572e32a99d Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 8 Apr 2020 19:26:08 -0700 Subject: [PATCH 1/2] fix: LTS release commit should contain codename --- lib/prepare_release.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/prepare_release.js b/lib/prepare_release.js index 4fdd18e2..c1f1f2f2 100644 --- a/lib/prepare_release.js +++ b/lib/prepare_release.js @@ -358,10 +358,10 @@ class ReleasePreparation { } async createReleaseCommit() { - const { cli, isLTS, newVersion, isSecurityRelease, date } = this; + const { cli, isLTS, ltsCodename, newVersion, isSecurityRelease, date } = this; - const releaseType = isLTS ? 'LTS' : 'Current'; - const messageTitle = `${date} Version ${newVersion} (${releaseType})`; + const releaseInfo = isLTS ? `'${ltsCodename}' (LTS)` : '(Current)'; + const messageTitle = `${date} Version ${newVersion} ${releaseInfo}`; const messageBody = []; if (isSecurityRelease) { From 237851d78f21cb154f6e89ce7b7c80e130fc96e1 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 8 Apr 2020 22:57:03 -0700 Subject: [PATCH 2/2] Fix line length lint issue --- lib/prepare_release.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/prepare_release.js b/lib/prepare_release.js index c1f1f2f2..23423635 100644 --- a/lib/prepare_release.js +++ b/lib/prepare_release.js @@ -358,7 +358,14 @@ class ReleasePreparation { } async createReleaseCommit() { - const { cli, isLTS, ltsCodename, newVersion, isSecurityRelease, date } = this; + const { + cli, + isLTS, + ltsCodename, + newVersion, + isSecurityRelease, + date + } = this; const releaseInfo = isLTS ? `'${ltsCodename}' (LTS)` : '(Current)'; const messageTitle = `${date} Version ${newVersion} ${releaseInfo}`;