From e4b379a471dc784985521ac10c963af312a17f96 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 20 Jul 2020 11:55:03 -0700 Subject: [PATCH 1/2] fix: get node-test-commit job id --- bin/ncu-ci | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/bin/ncu-ci b/bin/ncu-ci index c06b6946..b72c9545 100755 --- a/bin/ncu-ci +++ b/bin/ncu-ci @@ -239,8 +239,15 @@ class CICommand { case DAILY_MASTER: { const daily = new DailyBuild(cli, request, job.jobid); const data = await daily.getBuildData(); - build = new CommitBuild(cli, request, data.subBuilds[0].buildNumber); - break; + const testCommitBuild = data.subBuilds.filter(subBuild => { + return subBuild.jobName === 'node-test-commit'; + })[0]; + if (testCommitBuild) { + build = new CommitBuild(cli, request, testCommitBuild.buildNumber); + break; + } else { + throw new Error('Could not find \'node-test-commit\' job'); + } } default: throw new Error(`Unknown job type ${job.type}`); From 5d14b02169a80c4efa9c892dabbeea2741cda62b Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 20 Jul 2020 12:08:24 -0700 Subject: [PATCH 2/2] chore: remove unused setDailyBuildData --- lib/ci/ci_result_parser.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/ci/ci_result_parser.js b/lib/ci/ci_result_parser.js index 93754fe5..345f4809 100644 --- a/lib/ci/ci_result_parser.js +++ b/lib/ci/ci_result_parser.js @@ -225,13 +225,6 @@ class TestBuild extends Job { this.builtOn = builtOn; } - setDailyBuildData({ result, changeSet, actions, timestamp, builtOn }) { - this.change = changeSet.items[0] || {}; - this.date = new Date(timestamp); - this.result = result; - this.builtOn = builtOn; - } - get sourceURL() { const { params } = this;