Skip to content

fix(update-v8): force-add all files after cloning V8 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2021
Merged

fix(update-v8): force-add all files after cloning V8 #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/update-v8/majorUpdate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = function() {
removeDepsV8(),
cloneLocalV8(),
removeDepsV8Git(),
addDepsV8(),
updateV8Deps(),
applyNodeChanges()
]);
Expand Down Expand Up @@ -96,6 +97,17 @@ function removeDepsV8Git() {
};
}

function addDepsV8() {
return {
title: 'Track all files in deps/v8',
// Add all V8 files with --force before updating DEPS. We have to do this
// because some files are checked in by V8 despite .gitignore rules.
task: (ctx) => execa('git', ['add', '--force', 'deps/v8'], {
cwd: ctx.nodeDir
})
};
}

function updateV8Deps() {
return {
title: 'Update V8 DEPS',
Expand Down