Skip to content

Conversation

@ruyadorno
Copy link
Member

Adds an option that allows skipping the initial branch-diff check step in the release command. This should be very convenient for releasers that are updating a current work in progress proposal, particularly helping avoid hitting GitHub API rate limits.

Adds an option that allows skipping the initial `branch-diff` check step in the
release command. This should be very convenient for releasers that are updating
a current work in progress proposal, particularly helping avoid hitting GitHub
API rate limits.
@ruyadorno ruyadorno requested a review from RafaelGSS September 7, 2023 00:56
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.36% ⚠️

Comparison is base (4b2b6fa) 83.38% compared to head (d6b39b9) 83.03%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   83.38%   83.03%   -0.36%     
==========================================
  Files          37       37              
  Lines        4158     4178      +20     
==========================================
+ Hits         3467     3469       +2     
- Misses        691      709      +18     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 merged commit d103f28 into nodejs:main Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants