From 3f0365f1da15e7e0d0c087c3efaaae839cd562dd Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Fri, 22 Sep 2023 13:41:40 +0300 Subject: [PATCH 1/4] chore: remove EoL Node.js 16 from test matrix --- .github/workflows/nodejs.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index c74d6c13..56f128df 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -26,7 +26,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [16.x, 18.x, 20.x] + node-version: [18.x, 20.x] os: [ubuntu-latest, macOS-latest, windows-latest] runs-on: ${{ matrix.os }} steps: @@ -39,10 +39,6 @@ jobs: - name: Install dependencies run: npm install - name: Run tests - if: matrix.node-version == '16.x' - run: npm run test-unit - - name: Run tests - if: matrix.node-version != '16.x' run: npm run coverage:ci - name: Upload coverage report to Codecov uses: codecov/codecov-action@v3 From 42fb7364ced3eabef6bf6e27b28565d95f13608b Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sat, 23 Sep 2023 23:09:23 +0300 Subject: [PATCH 2/4] chore: update engines in package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 86087a82..480d49fd 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "description": "Utilities for Node.js core collaborators", "type": "module", "engines": { - "node": ">=16.8.0" + "node": ">=18.0.0" }, "bin": { "get-metadata": "./bin/get-metadata.js", From cd5c4f9297e1c9fc2bd89119c19e11892bf8b859 Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sun, 24 Sep 2023 00:50:54 +0300 Subject: [PATCH 3/4] chore: moved to prepare-node-test-matrix --- .github/workflows/nodejs.yml | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 56f128df..35b8e0f0 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -22,23 +22,13 @@ jobs: run: npm run lint test: - name: Test on Node.js ${{ matrix.node-version }} and ${{ matrix.os }} + name: Test on Node.js + uses: pkgjs/action/.github/workflows/node-test.yaml@v0 + with: + runs-on: ubuntu-latest, macos-latest + test-command: npm run coverage:ci + post-test-steps: | + - name: Upload coverage report to Codecov + uses: codecov/codecov-action@v3 strategy: fail-fast: false - matrix: - node-version: [18.x, 20.x] - os: [ubuntu-latest, macOS-latest, windows-latest] - runs-on: ${{ matrix.os }} - steps: - - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} - check-latest: true - - name: Install dependencies - run: npm install - - name: Run tests - run: npm run coverage:ci - - name: Upload coverage report to Codecov - uses: codecov/codecov-action@v3 From 84fe43f754d7ad5b2e51ad46025e75d7294aa92f Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sun, 24 Sep 2023 13:26:22 +0300 Subject: [PATCH 4/4] chore: remove support from node 16,17 and 19 Co-authored-by: Antoine du Hamel --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 480d49fd..279eacc4 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "description": "Utilities for Node.js core collaborators", "type": "module", "engines": { - "node": ">=18.0.0" + "node": "^18.18.0 || >=20.0.0" }, "bin": { "get-metadata": "./bin/get-metadata.js",