From 7be11798ba3eea3bda9bd5a4e3d8257c52d2b0b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 30 Sep 2024 11:18:03 +0200 Subject: [PATCH 1/2] fix(v8): mark boolean CLI options as such --- components/git/v8.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components/git/v8.js b/components/git/v8.js index 753c2e26..eb1c2fdb 100644 --- a/components/git/v8.js +++ b/components/git/v8.js @@ -6,6 +6,7 @@ import { minor, major, backport } from '../../lib/update-v8/index.js'; import { defaultBaseDir } from '../../lib/update-v8/constants.js'; import { checkCwd } from '../../lib/update-v8/common.js'; import { forceRunAsync } from '../../lib/run.js'; +import { type } from 'node:os'; export const command = 'v8 [major|minor|backport]'; export const describe = 'Update or patch the V8 engine'; @@ -22,6 +23,7 @@ export function builder(yargs) { default: 'lkgr' }); yargs.option('version-bump', { + type: 'boolean', describe: 'Bump the NODE_MODULE_VERSION constant', default: true }); @@ -39,10 +41,12 @@ export function builder(yargs) { builder: (yargs) => { yargs .option('bump', { + type: 'boolean', describe: 'Bump V8 embedder version number or patch version', default: true }) .option('squash', { + type: 'boolean', describe: 'If multiple commits are backported, squash them into one', default: false @@ -62,8 +66,8 @@ export function builder(yargs) { describe: 'Directory of an existing V8 clone' }) .option('verbose', { + type: 'boolean', describe: 'Enable verbose output', - boolean: true, default: false }); } From f79fd3e03eed76bc9788a72fe06994390e0cfb8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 30 Sep 2024 12:10:02 +0200 Subject: [PATCH 2/2] Update components/git/v8.js Co-authored-by: Antoine du Hamel --- components/git/v8.js | 1 - 1 file changed, 1 deletion(-) diff --git a/components/git/v8.js b/components/git/v8.js index eb1c2fdb..b0c2879e 100644 --- a/components/git/v8.js +++ b/components/git/v8.js @@ -6,7 +6,6 @@ import { minor, major, backport } from '../../lib/update-v8/index.js'; import { defaultBaseDir } from '../../lib/update-v8/constants.js'; import { checkCwd } from '../../lib/update-v8/common.js'; import { forceRunAsync } from '../../lib/run.js'; -import { type } from 'node:os'; export const command = 'v8 [major|minor|backport]'; export const describe = 'Update or patch the V8 engine';