This repository has been archived by the owner. It is now read-only.

proposal: `node inspect` CLI debugger #42

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jkrems

jkrems commented Sep 4, 2016

I think this came up during the original V8 inspector discussions.

P.S.: I created a POC port of lib/_debugger.js to the --inspect protocol to make sure this could reasonably be done in core without pulling in additional dependencies.

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Sep 8, 2016

I published the "polyfill" to npm as node-inspect (requires node 6):

npm install --global node-inspect

For the implementation status, see this tracking issue. Most things should work already.

jkrems commented Sep 8, 2016

I published the "polyfill" to npm as node-inspect (requires node 6):

npm install --global node-inspect

For the implementation status, see this tracking issue. Most things should work already.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 8, 2016

Member

This is definitely interesting but I'm wondering if it would be better to develop this as a standalone client for the time being. Once it's functional, then we can look to see how much sense it makes to bringing it in to core.

Member

jasnell commented Sep 8, 2016

This is definitely interesting but I'm wondering if it would be better to develop this as a standalone client for the time being. Once it's functional, then we can look to see how much sense it makes to bringing it in to core.

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Sep 8, 2016

That definitely makes sense. And I'm not looking to submit the code I linked to above to core in the next few days or immediately after this proposal is finalized/merged.

But my impression was that the current command line debugger is already depending on (more or less) unsupported parts of V8. So it seemed like a good idea to have an official plan for "the day it breaks". The proposal explicitly doesn't mention my repo. It just suggests a potential interface for transitioning the official built-in debugger from the old V8 protocol to the new inspector protocol.

jkrems commented Sep 8, 2016

That definitely makes sense. And I'm not looking to submit the code I linked to above to core in the next few days or immediately after this proposal is finalized/merged.

But my impression was that the current command line debugger is already depending on (more or less) unsupported parts of V8. So it seemed like a good idea to have an official plan for "the day it breaks". The proposal explicitly doesn't mention my repo. It just suggests a potential interface for transitioning the official built-in debugger from the old V8 protocol to the new inspector protocol.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 8, 2016

Member

btw, relevant to this: nodejs/node#7266

Member

jasnell commented Sep 8, 2016

btw, relevant to this: nodejs/node#7266

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Sep 8, 2016

Thanks for the link! Must've been blind. :)

jkrems commented Sep 8, 2016

Thanks for the link! Must've been blind. :)

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Sep 13, 2016

After playing around with the finished debugger - it feels like a wasted opportunity to go down this route.

jkrems commented Sep 13, 2016

After playing around with the finished debugger - it feels like a wasted opportunity to go down this route.

@jkrems jkrems closed this Sep 13, 2016

@jkrems jkrems deleted the jkrems:jk-node-inspect branch Sep 13, 2016

@jkrems jkrems referenced this pull request Oct 17, 2016

Closed

Bringing node-inspect into the fold #67

7 of 9 tasks complete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.