Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin,lib: remove extra comments/lines/spaces #1508

Merged
merged 2 commits into from Jul 28, 2018

Conversation

@maclover7
Copy link
Member

commented Jul 19, 2018

Checklist
  • npm install && npm test passes
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • Removes "module dependencies" comments and things that, IMHO, don't add
    too much value. Happy to add back if helps some people when reading
    through node-gyp.
  • DRY up lib/process-release.js.
  • Removes a bunch of extra blank lines, as well as random spaces.
- Removes "module dependencies" comments and things that, IMHO, don't add
too much value. Happy to add back if helps some people when reading
through `node-gyp`.
- DRY up `lib/process-release.js`.
- Removes a bunch of extra blank lines, as well as random spaces.
@maclover7

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2018

@@ -126,7 +118,6 @@ process.on('uncaughtException', function (err) {
})

function errorMessage () {
// copied from npm's lib/util/error-handler.js

This comment has been minimized.

Copy link
@richardlau

richardlau Jul 19, 2018

Member

This is sort of an attribution (although the current path in npm now appears to be lib/utils/error-handler.js), so maybe keep?

@maclover7

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2018

updated @richardlau, PTAL

@maclover7

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2018

@maclover7 maclover7 merged commit 6b0f4ae into nodejs:master Jul 28, 2018
@maclover7 maclover7 deleted the maclover7:jm-rm-extra branch Jul 28, 2018
@maclover7

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2018

Landed in 6b0f4ae, thank you for the review!

rvagg added a commit that referenced this pull request Apr 24, 2019
- Removes "module dependencies" comments and things that, IMHO, don't add
too much value. Happy to add back if helps some people when reading
through `node-gyp`.
- DRY up `lib/process-release.js`.
- Removes a bunch of extra blank lines, as well as random spaces.

PR-URL: #1508
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg rvagg referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.