Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve issue template #1618

Closed
wants to merge 2 commits into from

Conversation

@bzoz
Copy link
Contributor

commented Nov 28, 2018

Checklist
Description of change

Improve the issue template:

  • suggest using --verbose npm switch when providing logs
  • better direct users to use backticks correctly.
Suggest using --verbose npm switch when providing logs. Hopefully,
better direct users to use backticks correctly.
Paste your log here, between the backticks. It can be:
- npm --verbose output,
- or contents of npm-debug.log,
- or verbose build output.

This comment has been minimized.

Copy link
@joaocgreis

joaocgreis Nov 28, 2018

Member
Suggested change
- or verbose build output.
- output of `node-gyp rebuild --verbose`
Copy link
Member

left a comment

LGTM if you include João's suggestion.

@bzoz

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2018

I don't have write access here, can someone land this please?

joaocgreis added a commit that referenced this pull request Dec 19, 2018
Suggest using --verbose npm switch when providing logs. Hopefully,
better direct users to use backticks correctly.

PR-URL: #1618
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@joaocgreis

This comment has been minimized.

Copy link
Member

commented Dec 19, 2018

@joaocgreis joaocgreis closed this Dec 19, 2018
rvagg added a commit that referenced this pull request Apr 24, 2019
Suggest using --verbose npm switch when providing logs. Hopefully,
better direct users to use backticks correctly.

PR-URL: #1618
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.