Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated compatibility code. #1670

Merged
merged 2 commits into from May 6, 2019

Conversation

@bnoordhuis
Copy link
Member

commented Feb 14, 2019

  • Remove support for the IOJS_ORG_MIRROR, NVM_IOJS_ORG_MIRROR
    and NVM_NODEJS_ORG_MIRROR enviroment variables.

  • Remove obsolete support for io.js. It's been out of support
    for over three years now.

@@ -3,7 +3,6 @@
#set -e

test_node_versions="0.8.28 0.10.40 0.12.7 4.3.0 5.6.0"

This comment has been minimized.

Copy link
@richardlau

richardlau Feb 14, 2019

Member

Should we be updating these (perhaps in a different PR) to in support versions of Node.js?

This comment has been minimized.

Copy link
@bnoordhuis

bnoordhuis Feb 15, 2019

Author Member

Yep, good idea. I could do that as a separate commit or a separate PR.

This comment has been minimized.

Copy link
@richardlau

richardlau Feb 15, 2019

Member

Yep, good idea. I could do that as a separate commit or a separate PR.

Your choice 😄

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Updated after some delay... CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/116/ (edit: green!)

@rvagg rvagg force-pushed the nodejs:master branch from 1456ef2 to 7a71d68 Apr 24, 2019
@bnoordhuis bnoordhuis force-pushed the bnoordhuis:rm-compat-code branch from 697f265 to b4f4c88 May 6, 2019
bnoordhuis added 2 commits Feb 14, 2019
* Remove support for the IOJS_ORG_MIRROR, NVM_IOJS_ORG_MIRROR
  and NVM_NODEJS_ORG_MIRROR enviroment variables.

* Remove obsolete support for io.js. It's been out of support
  for over three years now.

PR-URL: #1670
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #1670
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@bnoordhuis bnoordhuis force-pushed the bnoordhuis:rm-compat-code branch from b4f4c88 to 81f3a92 May 6, 2019
@bnoordhuis bnoordhuis closed this May 6, 2019
@bnoordhuis bnoordhuis deleted the bnoordhuis:rm-compat-code branch May 6, 2019
@bnoordhuis bnoordhuis merged commit 81f3a92 into nodejs:master May 6, 2019
@rvagg rvagg referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.