Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update macOS_Catalina.md #1992

Merged
merged 4 commits into from
Dec 29, 2019
Merged

doc: update macOS_Catalina.md #1992

merged 4 commits into from
Dec 29, 2019

Conversation

jameshome
Copy link
Contributor

The fixes suggested in macOS_Catalina.md are not working reliably in the latest versions of Catalina. @rrrix found that installing the Command Line Tools from dmg rather than xcode-select --install does work. This was confirmed by two other people, including myself.

Checklist
  • documentation is changed or added

suraneti and others added 2 commits December 13, 2019 14:19
PR-URL: nodejs#1985
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
The fixes suggested in macOS_Catalina.md are not working reliably in the latest versions of Catalina. @rrrix found that installing the Command Line Tools from dmg rather than xcode-select --install does work. This was confirmed by two other people, including myself.
macOS_Catalina.md Outdated Show resolved Hide resolved
macOS_Catalina.md Outdated Show resolved Hide resolved
macOS_Catalina.md Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Dec 15, 2019

will defer to @cclauss on final approval of this

@jameshome
Copy link
Contributor Author

@cclauss Anything more you need from me on this? There have been another half dozen posts to 1927, so this is impacting a lot of folks right now.

@gengjiawen gengjiawen changed the title Update macOS_Catalina.md doc: update macOS_Catalina.md Dec 29, 2019
@gengjiawen gengjiawen merged commit 312c12e into nodejs:master Dec 29, 2019
@gengjiawen
Copy link
Member

Thanks for the contribution ❤️

rvagg pushed a commit that referenced this pull request Jan 3, 2020
PR-URL: #1992
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants