Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Rename and update Common-issues.md --> docs/README.md #2567

Merged
merged 1 commit into from Dec 13, 2021
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 7, 2021

Update the common problems to track with current issues on this repo and shorten the URL to just
https://github.com/nodejs/node-gyp/tree/master/docs

rvagg
rvagg approved these changes Dec 8, 2021
Copy link
Member

@rvagg rvagg left a comment

when you squash and merge make sure you rename the final commit message so it fits in nicely with a proper doc: prefix

Update the common problems to track with current issues on this repo and shorten the URL to just https://github.com/nodejs/node-gyp/tree/master/docs
@cclauss cclauss changed the title docs: Rename and update Common-issues.md --> docs/README.md doc: Rename and update Common-issues.md --> docs/README.md Dec 8, 2021
@cclauss cclauss requested a review from gengjiawen Dec 9, 2021
@cclauss cclauss merged commit 2ef5fb8 into master Dec 13, 2021
56 checks passed
@cclauss cclauss deleted the docs/README.md branch Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants