Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add notes/disclaimers for upgrading the copy of node-gyp that npm uses #2585

Merged
merged 2 commits into from Jan 6, 2022

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Jan 6, 2022

Checklist
Description of change

Add notes on npm version compatibility for methods to update the copy of node-gyp that npm uses.

Also mention that this is tested on npm 8, now that npm 8 exists. (Npm 8 is the same as npm 7 for purposes of these instructions.)

Lastly, add a note that one of the methods is simpler/more durable, but only functional for npm 6 and older.

Add notes on npm version compatibility for methods to update node-gyp.

Also mention that this is tested on npm 8, now that npm 8 exists.
(Npm 8 is the same as npm 7 for purposes of these instructions.)

Lastly, add a note that one of the methods is simpler/more durable,
if only functional for npm 6 and older.
@DeeDeeG DeeDeeG mentioned this pull request Jan 6, 2022
4 tasks
docs/Updating-npm-bundled-node-gyp.md Outdated Show resolved Hide resolved
Use relative (current dir) links, rather than absolute web URLs.

Co-authored-by: Rod Vagg <rod@vagg.org>
@DeeDeeG DeeDeeG force-pushed the caveats-for-npm-upgrade-docs branch from 369828a to 583abb4 Compare Jan 6, 2022
@DeeDeeG
Copy link
Contributor Author

@DeeDeeG DeeDeeG commented Jan 6, 2022

Made the links relative, thanks for pointing that out.

@rvagg rvagg merged commit faf6d48 into nodejs:master Jan 6, 2022
28 checks passed
@rvagg
Copy link
Member

@rvagg rvagg commented Jan 6, 2022

sgtm, as mentioned in the previous docs PR, we should try out faster merges on these doc PRs
thanks @DeeDeeG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants