Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rephrase explanation of which node-gyp is used by npm #2587

merged 4 commits into from Jan 7, 2022


Copy link

@owl-from-hogvarts owl-from-hogvarts commented Jan 6, 2022

  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Previous explanation went too deep regarding details about files hierarchy of npm. This info may mislead windows users since in windows npm is located in other place than global node_modules.

Also some minor changes like highlighting keywords and using direct names instead of pronouns

owl-from-hogvarts and others added 3 commits Jan 7, 2022
Co-authored-by: Rod Vagg <>
Co-authored-by: Rod Vagg <>
Co-authored-by: Rod Vagg <>
Copy link
Contributor Author

@owl-from-hogvarts owl-from-hogvarts commented Jan 7, 2022

@rvagg thank you for review. Your changes are applyed

rvagg approved these changes Jan 7, 2022
@rvagg rvagg merged commit a2f2988 into nodejs:master Jan 7, 2022
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants