Import local gyp.py, then fallback to system #397

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@caruccio

caruccio commented Feb 7, 2014

Some hosts have an old gyp version, which causes an ImportError.
It is better to import newer gyp.py first, then fallback to system-wide version.

Import local gyp.py, then fallback to system
Some hosts have an old gyp version, which causes an ImportError.
It is better to import newer gyp.py first, then fallback to system-wide version.
@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Mar 4, 2014

Collaborator

Is there a way to achieve this using env variables instead? We can't change any files in the gyp directory since they're from upstream gyp.

Collaborator

TooTallNate commented Mar 4, 2014

Is there a way to achieve this using env variables instead? We can't change any files in the gyp directory since they're from upstream gyp.

@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Mar 4, 2014

Collaborator

Failing that, it would be better if you proposed this patch to upstream gyp. I'm happy to float it once the upstream gyp guys have merged it.

Collaborator

TooTallNate commented Mar 4, 2014

Failing that, it would be better if you proposed this patch to upstream gyp. I'm happy to float it once the upstream gyp guys have merged it.

@caruccio

This comment has been minimized.

Show comment Hide comment
@caruccio

caruccio Mar 12, 2014

Thanks. Will do that and update this PR.

Thanks. Will do that and update this PR.

@caruccio

This comment has been minimized.

Show comment Hide comment
@caruccio

caruccio Mar 12, 2014

Patch submitted to review: https://codereview.chromium.org/197063002

Patch submitted to review: https://codereview.chromium.org/197063002

@patrys

This comment has been minimized.

Show comment Hide comment
@patrys

patrys May 6, 2014

Contributor

A workaround would be to set PYTHONPATH.

Contributor

patrys commented May 6, 2014

A workaround would be to set PYTHONPATH.

@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate May 24, 2015

Collaborator

This was fixed via PYTHONPATH in 52e8d9f.

Collaborator

TooTallNate commented May 24, 2015

This was fixed via PYTHONPATH in 52e8d9f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment