Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Import local gyp.py, then fallback to system #397
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
TooTallNate
Mar 4, 2014
Collaborator
Is there a way to achieve this using env variables instead? We can't change any files in the gyp directory since they're from upstream gyp.
|
Is there a way to achieve this using env variables instead? We can't change any files in the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
TooTallNate
Mar 4, 2014
Collaborator
Failing that, it would be better if you proposed this patch to upstream gyp. I'm happy to float it once the upstream gyp guys have merged it.
|
Failing that, it would be better if you proposed this patch to upstream gyp. I'm happy to float it once the upstream gyp guys have merged it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
caruccio
commented
Mar 12, 2014
|
Thanks. Will do that and update this PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
caruccio
commented
Mar 12, 2014
|
Patch submitted to review: https://codereview.chromium.org/197063002 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
|
A workaround would be to set |
TooTallNate
added
the
gyp upstream issue / floating patch
label
May 24, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
This was fixed via PYTHONPATH in 52e8d9f. |
caruccio commentedFeb 7, 2014
Some hosts have an old gyp version, which causes an ImportError.
It is better to import newer gyp.py first, then fallback to system-wide version.