Allow for npmlog@3.x #950
Closed
Allow for npmlog@3.x #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmlog version 3 switches to gauge version 2. The interface change is in setGaugeTemplate, which node-gyp does not use.
bnoordhuis
pushed a commit
that referenced
this pull request
Jun 7, 2016
npmlog version 3 switches to gauge version 2. The interface change is in setGaugeTemplate, which node-gyp does not use. PR-URL: #950 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks, landed in 3df8222. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npmlog version 3 switches to gauge version 2. The interface change is in
setGaugeTemplate, which node-gyp does not use.
(Allowing version 3, will let npm dedupe npmlog. As it is, we'll have two copies.)