Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset executable bit for .bat files #969

Closed
wants to merge 1 commit into from
Closed

Conversation

pmed
Copy link
Contributor

@pmed pmed commented Jun 26, 2016

On Windows this bit is not meaningful, on Posix systems such files
should not be executable.

On Windows this bit is not meaningful, on Posix systems such files
should not be executable.
@pmed pmed mentioned this pull request Jun 26, 2016
@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

@nodejs/platform-windows

@RReverser
Copy link
Member

Makes sense, LGTM to me.

bnoordhuis pushed a commit that referenced this pull request Oct 7, 2016
On Windows this bit is not meaningful, on Posix systems such files
should not be executable.

PR-URL: #969
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
@bnoordhuis
Copy link
Member

Landed in afc766a, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants