Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

tls: does not emit 'end' from EncryptedStream

de09168 and 4cdf9d4 breaks `test/pummel/test-https-large-response.js`.
It is never finished.

Fixes #1936.
  • Loading branch information...
koichik committed Oct 25, 2011
1 parent 13871fa commit 0e8a55d2a22b88dc3b9b0165f344602b0fa8c977
Showing with 100 additions and 1 deletion.
  1. +0 −1 lib/tls.js
  2. +100 −0 test/simple/test-tls-pause-close.js
@@ -713,7 +713,6 @@ SecurePair.prototype.destroy = function() {
self.cleartext.writable = self.cleartext.readable = false;

process.nextTick(function() {
self.encrypted.emit('end');
self.cleartext.emit('end');
self.encrypted.emit('close');
self.cleartext.emit('close');
@@ -0,0 +1,100 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

if (!process.versions.openssl) {
console.error('Skipping because node compiled without OpenSSL.');
process.exit(0);
}

var common = require('../common');
var assert = require('assert');
var tls = require('tls');
var fs = require('fs');
var path = require('path');

var serverClosed = false;
var serverSocketClosed = false;
var clientClosed = false;
var clientSocketClosed = false;

var options = {
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'))
};

var server = tls.createServer(options, function(s) {
console.log('server connected');
s.socket.on('end', function() {
console.log('server socket ended');
});
s.socket.on('close', function() {
console.log('server socket closed');
serverSocketClosed = true;
});
s.on('end', function() {
console.log('server ended');
});
s.on('close', function() {
console.log('server closed');
serverClosed = true;
});
s.pause();
console.log('server paused');
process.nextTick(function() {
s.resume();
console.log('server resumed');
});
s.end();
});

server.listen(common.PORT, function() {
var c = tls.connect(common.PORT, function() {
console.log('client connected');
c.socket.on('end', function() {
console.log('client socket ended');
});
c.socket.on('close', function() {
console.log('client socket closed');
clientSocketClosed = true;
});
c.pause();
console.log('client paused');
process.nextTick(function() {
c.resume();
console.log('client resumed');
});
});
c.on('end', function() {
console.log('client ended');
});
c.on('close', function() {
console.log('client closed');
clientClosed = true;
server.close();
});
});

process.on('exit', function() {
assert(serverClosed);
assert(serverSocketClosed);
assert(clientClosed);
assert(clientSocketClosed);
});

3 comments on commit 0e8a55d

@ry

This comment has been minimized.

Copy link

replied Nov 4, 2011

this breaks tls-peer-certificate on windows

@koichik

This comment has been minimized.

Copy link
Author

replied Nov 5, 2011

It seems to be caused by libuv's incompatibility between Unix and Windows.
example:

var net = require('net');
var server = net.createServer(function(s) {
  console.log('server connected');
  s.write('Hello');
  s.on('close', function() {
    server.close();
  });
});
server.listen(3000, function() {
  var c = net.connect(3000, function() {
    console.log('client connected');
    c.write('Hello');
    c.destroy();
  });
});

Unix:

client connected
server connected

Windows:

client connected
server connected

node.js:201
        throw e; // process.nextTick error, or 'error' event on first tick
              ^
Error: read ECONNABORTED
    at errnoException (net.js:614:11)
    at TCP.onread (net.js:355:20)

Because socket has been already closed, I think that an error should not occur.

@igorzi

This comment has been minimized.

Copy link

replied Nov 7, 2011

The ECONNABORTED happens on the server in the example above. It happens because the server's write never got read by the client. The client connects to the server, writes, and closes the socket. The server tries to write to the socket, but that write doesn't actually succeed (it just gets buffered to winsock) because the connection already got closed on the client side. After several failed retransmitions winsock aborts the connection on the server, which results in WSAECONNABORTED from WSARecv. If the above example is rewritten to have the client read server's response before closing the socket - ECONNABORTED goes away.

One way to fix this would be to just convert WSAECONNABORTED to EOF in libuv. WSAECONNABORTED essentially means EOF while also indicating that a write didn't succeed because the connection got closed on the other end. @piscisaureus what do you think?

Please sign in to comment.
You can’t perform that action at this time.