This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Fix #1497 querystring: Replace 'in' test with 'hasOwnProperty'

  • Loading branch information...
isaacs committed Aug 11, 2011
1 parent d1a2628 commit 3210809d0acac59df9fbd887d4e45047b2a82507
Showing with 7 additions and 2 deletions.
  1. +1 −1 lib/querystring.js
  2. +6 −1 test/simple/test-querystring.js
View
@@ -166,7 +166,7 @@ QueryString.parse = QueryString.decode = function(qs, sep, eq) {
var k = QueryString.unescape(x[0], true);
var v = QueryString.unescape(x.slice(1).join(eq), true);
- if (!(k in obj)) {
+ if (!obj.hasOwnProperty(k)) {
obj[k] = v;
} else if (!Array.isArray(obj[k])) {
obj[k] = [obj[k], v];
@@ -48,7 +48,12 @@ var qsTestCases = [
'undef': ''}],
[' foo = bar ', '%20foo%20=%20bar%20', {' foo ': ' bar '}],
['foo=%zx', 'foo=%25zx', {'foo': '%zx'}],
- ['foo=%EF%BF%BD', 'foo=%EF%BF%BD', {'foo': '\ufffd' }]
+ ['foo=%EF%BF%BD', 'foo=%EF%BF%BD', {'foo': '\ufffd' }],
+ [ 'toString=foo&valueOf=bar&__defineGetter__=baz',
+ 'toString=foo&valueOf=bar&__defineGetter__=baz',
+ { toString: 'foo',
+ valueOf: 'bar',
+ __defineGetter__: 'baz' } ]
];
// [ wonkyQS, canonicalQS, obj ]

0 comments on commit 3210809

Please sign in to comment.