This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Rename spawnNode to fork

  • Loading branch information...
ry committed May 11, 2011
1 parent 7ea7094 commit 337c48db5fe06ddaf626b03b7db6c6f48c5d3b62
@@ -179,7 +179,7 @@ amount of data allowed on stdout or stderr - if this value is exceeded then
the child process is killed.
-### child_process.spawnNode(modulePath, arguments, options)
+### child_process.fork(modulePath, arguments, options)
This is a special case of the `spawn()` functionality for spawning Node
processes. In addition to having all the methods in a normal ChildProcess
@@ -191,7 +191,7 @@ For example:
var cp = require('child_process');
- var n = cp.spawnNode(__dirname + '/sub.js');
+ var n = cp.fork(__dirname + '/sub.js');
n.on('message', function(m) {
console.log('PARENT got message:', m);
View
@@ -59,7 +59,7 @@ function setupChannel(target, fd) {
}
-exports.spawnNode = function(modulePath, args, options) {
+exports.fork = function(modulePath, args, options) {
if (!options) options = {};
options.wantChannel = true;
@@ -81,7 +81,7 @@ exports.spawnNode = function(modulePath, args, options) {
};
-exports._spawnNodeChild = function(fd) {
+exports._forkChild = function(fd) {
setupChannel(process, fd);
};
View
@@ -317,7 +317,7 @@
var fd = parseInt(process.env.NODE_CHANNEL_FD);
assert(fd >= 0);
var cp = NativeModule.require('child_process');
- cp._spawnNodeChild(fd);
+ cp._forkChild(fd);
assert(process.send);
}
}
@@ -345,7 +345,7 @@ int ChildProcess::Spawn(const char *file,
}
- // The channel will be used by spawnNode() for a little JSON channel.
+ // The channel will be used by js-land "fork()" for a little JSON channel.
// The pointer is used to pass one end of the socket pair back to the
// parent.
// channel_fds[0] is for the parent
@@ -1,8 +1,8 @@
var assert = require('assert');
var common = require('../common');
-var spawnNode = require('child_process').spawnNode;
+var fork = require('child_process').fork;
-var n = spawnNode(common.fixturesDir + '/child-process-spawn-node.js');
+var n = fork(common.fixturesDir + '/child-process-spawn-node.js');
var messageCount = 0;

3 comments on commit 337c48d

Isn't that confusing with respect to the actual fork() sys call?

ry replied May 12, 2011

That's what I thought originally but the unix-y people at Joyent don't mind. "Fork" is cute.

It's cute indeed. Just brings back sad memories of having my actual fork patch rejected ; )

Please sign in to comment.