Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

util: improve util.isDate() function

The old implementation was fragile. i.e. node-time is an example of a user-land
module that exports an extended Date object (with a few added functions on it's
own Date object's prototype). In that case, the old check fails.
  • Loading branch information...
TooTallNate authored and bnoordhuis committed Aug 31, 2011
1 parent 2b0a7d6 commit 44574bc39b93c96d9bd15e79757cf2eec501ac3a
Showing with 2 additions and 5 deletions.
  1. +2 −5 lib/util.js
@@ -332,11 +332,8 @@ function isRegExp(re) {


function isDate(d) {
if (d instanceof Date) return true;
if (typeof d !== 'object') return false;
var properties = Date.prototype && Object.getOwnPropertyNames(Date.prototype);
var proto = d.__proto__ && Object.getOwnPropertyNames(d.__proto__);
return JSON.stringify(proto) === JSON.stringify(properties);
return d instanceof Date ||
(typeof d === 'object' && Object.prototype.toString.call(d) === '[object Date]');
}


0 comments on commit 44574bc

Please sign in to comment.
You can’t perform that action at this time.