Permalink
Browse files

zlib: fix include of zlib.h

Including <zlib.h> may lead to false positives when the user specifies a bad
path in `./configure --shared-zlib --shared-zlib-includes=/path/to/zlib`. If
a zlib.h exists somewhere on the system include path (common on UNIX systems),
the compiler will include that instead, possibly leading to header mismatch
errors that are hard to debug.
  • Loading branch information...
1 parent 677c2c1 commit 531eba18a67805f7a95d20f7f9e684d83c5091b6 @bnoordhuis bnoordhuis committed Mar 12, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/node_zlib.cc
View
2 src/node_zlib.cc
@@ -25,8 +25,8 @@
#include <string.h>
#include <stdlib.h>
#include <sys/types.h>
-#include <zlib.h>
+#include "zlib.h"
#include "node.h"
#include "node_buffer.h"

0 comments on commit 531eba1

Please sign in to comment.