Permalink
Browse files

build: disable -fvisibility=hidden if gcc < 4.0.0

  • Loading branch information...
1 parent 5062741 commit 5ebc05f56018d5ced52e4c41f9e8a92c425253e3 @bnoordhuis bnoordhuis committed Mar 5, 2012
Showing with 3 additions and 3 deletions.
  1. +3 −3 configure
View
@@ -215,9 +215,9 @@ def configure_node(o):
o['variables']['strict_aliasing'] = b(
'clang' in CC or gcc_version() >= [False, 4, 6, 0])
- # TODO move to node.gyp
- if sys.platform == 'sunos5':
- o['variables']['visibility'] = '' # FIXME -fvisibility=hidden, should be a gcc check
+ # clang has always supported -fvisibility=hidden, right?
+ if 'clang' not in CC and gcc_version() < [False, 4, 0, 0]:
+ o['variables']['visibility'] = ''
def configure_libz(o):

0 comments on commit 5ebc05f

Please sign in to comment.