This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

object_wrap: add missing HandleScope

by Sven Panne's suggestion, see [0] for details.

[0]: https://code.google.com/p/v8/issues/detail?id=2468
  • Loading branch information...
indutny committed Jan 4, 2013
1 parent 0054264 commit 97056c064fd45e17471c682d1cbcdd925dc0c84e
Showing with 2 additions and 0 deletions.
  1. +2 −0 src/node_object_wrap.h
View
@@ -112,6 +112,8 @@ class NODE_EXTERN ObjectWrap {
private:
static void WeakCallback (v8::Persistent<v8::Value> value, void *data) {
+ v8::HandleScope scope;
+
ObjectWrap *obj = static_cast<ObjectWrap*>(data);
assert(value == obj->handle_);
assert(!obj->refs_);

4 comments on commit 97056c0

@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Jan 7, 2013

This should probably be backported to v0.8 branch.

This should probably be backported to v0.8 branch.

@indutny

This comment has been minimized.

Show comment Hide comment
@indutny

indutny Jan 8, 2013

Member

Agree. @bnoordhuis ok?

Member

indutny replied Jan 8, 2013

Agree. @bnoordhuis ok?

@bnoordhuis

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Jan 8, 2013

Member

Sure. Though it's kind of pointless unless people recompile their add-ons.

Member

bnoordhuis replied Jan 8, 2013

Sure. Though it's kind of pointless unless people recompile their add-ons.

@indutny

This comment has been minimized.

Show comment Hide comment
@indutny

indutny Jan 9, 2013

Member

Ok, landed in 7a2ae4c

Member

indutny replied Jan 9, 2013

Ok, landed in 7a2ae4c

Please sign in to comment.