Skip to content
Browse files

build: fix mksnapshot crash on sunos

Unconditionally compile V8 with -fno-strict-aliasing on all platforms.

gcc 4.5.2 on sunos generates bad code when -fstrict-aliasing is enabled, which
undoubtedly means that there are more buggy versions of gcc out there.

-fstrict-aliasing does not give a significant performance boost so let's just
disable it.

Fixes #3736.
  • Loading branch information...
1 parent beb7425 commit 98b1ce91f6ab65b88b759e7ada18133b9257b203 @bnoordhuis bnoordhuis committed
Showing with 2 additions and 0 deletions.
  1. +2 −0 configure
View
2 configure
@@ -265,6 +265,8 @@ def compiler_version():
def configure_node(o):
+ # TODO add gdb
+ o['variables']['v8_no_strict_aliasing'] = 1 # work around compiler bugs
o['variables']['node_prefix'] = os.path.expanduser(options.prefix or '')
o['variables']['node_install_npm'] = b(not options.without_npm)
o['variables']['node_install_waf'] = b(not options.without_waf)

0 comments on commit 98b1ce9

Please sign in to comment.
Something went wrong with that request. Please try again.