Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
dgram: pass the bytes sent to the send callback
Browse files Browse the repository at this point in the history
Fixes #6953
  • Loading branch information
tjfontaine committed Feb 16, 2014
1 parent 3421d29 commit a4436ba
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/dgram.js
Expand Up @@ -319,7 +319,7 @@ Socket.prototype.send = function(buffer,


function afterSend(err) {
this.callback(err ? errnoException(err, 'send') : null);
this.callback(err ? errnoException(err, 'send') : null, this.buffer.length);
}


Expand Down
31 changes: 31 additions & 0 deletions test/simple/test-dgram-bytes-length.js
@@ -0,0 +1,31 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

var common = require('../common');
var assert = require('assert');
var dgram = require('dgram');

var message = new Buffer('Some bytes');
var client = dgram.createSocket('udp4');
client.send(message, 0, message.length, 41234, "localhost", function(err, bytes) {
assert.strictEqual(bytes, message.length);
client.close();
});

0 comments on commit a4436ba

Please sign in to comment.