Permalink
Browse files

build: unbreak ustack on smartos

I disabled the -ffunction-sections and -fdata-sections switches in 202df30
because they're horribly buggy with some gcc/binutils combos.

However, it turns out that the dtrace/ustack post-processing tool requires
that V8 is compiled with said switches and was broken because of it.

This commit turns them on again on SunOS systems. Let's hope for the best.
  • Loading branch information...
1 parent 5a5e128 commit b2648934f013ccdf1a15bb74a5480d5a42a97943 @bnoordhuis bnoordhuis committed Jul 19, 2012
Showing with 14 additions and 7 deletions.
  1. +14 −7 common.gypi
View
@@ -46,18 +46,25 @@
},
'Release': {
'conditions': [
+ ['target_arch=="x64"', {
+ 'msvs_configuration_platform': 'x64',
+ }],
['node_unsafe_optimizations==1', {
'cflags': [ '-O3', '-ffunction-sections', '-fdata-sections' ],
'ldflags': [ '-Wl,--gc-sections' ],
}, {
'cflags': [ '-O2', '-fno-strict-aliasing', '-fno-tree-vrp' ],
- 'cflags!': [ '-O3',
- '-fstrict-aliasing',
- '-ffunction-sections',
- '-fdata-sections' ],
- }],
- ['target_arch=="x64"', {
- 'msvs_configuration_platform': 'x64',
+ 'cflags!': [ '-O3', '-fstrict-aliasing' ],
+ 'conditions': [
+ # Required by the dtrace post-processor. Unfortunately,
+ # some gcc/binutils combos generate bad code when
+ # -ffunction-sections is enabled. Let's hope for the best.
+ ['OS=="solaris"', {
+ 'cflags': [ '-ffunction-sections', '-fdata-sections' ],
+ }, {
+ 'cflags!': [ '-ffunction-sections', '-fdata-sections' ],
+ }],
+ ],
}],
['OS=="solaris"', {
'cflags': [ '-fno-omit-frame-pointer' ],

0 comments on commit b264893

Please sign in to comment.