Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Fix #3231. Don't try to emit error on a null'ed req object

  • Loading branch information...
isaacs committed May 7, 2012
1 parent e02af94 commit b4fbf6d27590e0fae42cc39adca9694793efdce1
Showing with 8 additions and 5 deletions.
  1. +8 −5 lib/http.js
@@ -1158,18 +1158,21 @@ ClientRequest.prototype.onSocket = function(socket) {
// Setup "drain" propogation.
httpSocketSetup(socket);

var errorListener = function(err) {
function errorListener(err) {
debug('HTTP SOCKET ERROR: ' + err.message + '\n' + err.stack);
req.emit('error', err);
// For Safety. Some additional errors might fire later on
// and we need to make sure we don't double-fire the error event.
req._hadError = true;
if (req) {
req.emit('error', err);
// For Safety. Some additional errors might fire later on
// and we need to make sure we don't double-fire the error event.
req._hadError = true;
}
if (parser) {
parser.finish();
freeParser(parser, req);
}
socket.destroy();
}

socket.on('error', errorListener);

socket.ondata = function(d, start, end) {

0 comments on commit b4fbf6d

Please sign in to comment.
You can’t perform that action at this time.