Skip to content
Browse files

dgram: fix when we call .close() inside 'listening'

  • Loading branch information...
1 parent b602390 commit b72d43cbf9116fb5eb0dc92006dbc180d4db7d3e ssuda committed with bnoordhuis
Showing with 33 additions and 1 deletion.
  1. +1 −1 lib/dgram.js
  2. +32 −0 test/simple/test-dgram-bind.js
View
2 lib/dgram.js
@@ -124,8 +124,8 @@ Socket.prototype.bind = function(port, address) {
}
else {
self._bound = true;
- self.emit('listening');
self._startReceiving();
+ self.emit('listening');
}
}
View
32 test/simple/test-dgram-bind.js
@@ -0,0 +1,32 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common');
+var assert = require('assert');
+var dgram = require('dgram');
+
+var socket = dgram.createSocket('udp4');
+
+socket.on('listening', function () {
+ socket.close();
+});
+
+socket.bind(); // should not throw

0 comments on commit b72d43c

Please sign in to comment.
Something went wrong with that request. Please try again.