Permalink
Browse files

Parse the command line before initializing V8.

Doing it the other way around means that V8 won't pick
up command line switches like `--prof`.

Props to Joshua Kehn for reporting the issue and Jeff Fifield
for pointing out the cause.

Fixes #900.
Fixes #1217.
  • Loading branch information...
1 parent 72e18d7 commit b74d119b3487b62d81908c76151f252edd46e6cc @bnoordhuis bnoordhuis committed with ry Jun 23, 2011
Showing with 4 additions and 2 deletions.
  1. +4 −2 src/node.cc
View
@@ -2486,11 +2486,13 @@ void EmitExit(v8::Handle<v8::Object> process) {
int Start(int argc, char *argv[]) {
uv_init();
- v8::V8::Initialize();
- v8::HandleScope handle_scope;
+ // This needs to run *before* V8::Initialize()
argv = Init(argc, argv);
+ v8::V8::Initialize();
+ v8::HandleScope handle_scope;
+
// Create the one and only Context.
Persistent<v8::Context> context = v8::Context::New();
v8::Context::Scope context_scope(context);

0 comments on commit b74d119

Please sign in to comment.