Permalink
Browse files

cluster: make 'listening' handler see actual port

Make the 'listening' event handler in the master process see the actual port
that the worker bound to when the worker specified port 0, i.e. a random port.
  • Loading branch information...
1 parent 8bd4590 commit c668185adde3a474585a11f172b8387e270ec23b @aadityabhatia aadityabhatia committed with bnoordhuis Oct 9, 2012
Showing with 45 additions and 1 deletion.
  1. +1 −1 lib/cluster.js
  2. +44 −0 test/simple/test-cluster-listening-port.js
View
@@ -535,7 +535,7 @@ cluster._getServer = function(tcpSelf, address, port, addressType, fd, cb) {
sendInternalMessage(cluster.worker, {
cmd: 'listening',
address: address,
- port: port,
+ port: tcpSelf.address().port || port,
addressType: addressType,
fd: fd
});
@@ -0,0 +1,44 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var assert = require('assert');
+var cluster = require('cluster');
+var net = require('net');
+
+if (cluster.isMaster) {
+ var port = null;
+ cluster.fork();
+ cluster.on('listening', function(worker, address) {
+ port = address.port;
+ // ensure that the port is not 0 or null
+ assert(port);
+ // ensure that the port is numerical
+ assert.strictEqual(typeof(port), 'number');
+ worker.destroy();
+ });
+ process.on('exit', function() {
+ // ensure that the 'listening' handler has been called
+ assert(port);
+ });
+}
+else {
+ net.createServer(assert.fail).listen(0);
+}

0 comments on commit c668185

Please sign in to comment.