Permalink
Browse files

cluster: don't silently drop messages when the write queue gets big

  • Loading branch information...
1 parent 2301eb6 commit cfa28690db6532972fc9ec90ff874b400ca3a0a5 @piscisaureus piscisaureus committed Jun 11, 2012
Showing with 2 additions and 6 deletions.
  1. +2 −6 lib/child_process.js
View
@@ -329,11 +329,6 @@ function setupChannel(target, channel) {
return;
}
- // For overflow protection don't write if channel queue is too deep.
- if (channel.writeQueueSize > 1024 * 1024) {
- return false;
- }
-
// package messages with a handle object
if (handle) {
// this message will be handled by an internalMessage event handler
@@ -379,7 +374,8 @@ function setupChannel(target, channel) {
writeReq.oncomplete = nop;
- return true;
+ /* If the master is > 2 read() calls behind, please stop sending. */
+ return channel.writeQueueSize < (65536 * 2);
};
target.connected = true;

0 comments on commit cfa2869

Please sign in to comment.