This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Bugfix: Negative ints in HTTP's on_body and node.fs.read()

Similar to the error fixed in
9d3ed1b.

Reported by Felix Geisendörfer.
  • Loading branch information...
1 parent 75fc215 commit ed8c43d2f3d20dec77a1206cfe80b8dfb5db5811 @ry ry committed Aug 9, 2009
Showing with 3 additions and 2 deletions.
  1. +2 −1 src/file.cc
  2. +1 −1 src/http.cc
View
@@ -285,7 +285,8 @@ AfterRawRead(eio_req *req)
size_t len = req->result;
Local<Array> array = Array::New(len);
for (unsigned int i = 0; i < len; i++) {
- array->Set(Integer::New(i), Integer::New(buf[i]));
+ unsigned char val = reinterpret_cast<const unsigned char*>(buf)[i];
+ array->Set(Integer::New(i), Integer::New(val));
}
argv[0] = array;
argv[1] = Integer::New(req->result);
View
@@ -196,7 +196,7 @@ HTTPConnection::on_body (http_parser *parser, const char *buf, size_t len)
// raw encoding
Local<Array> array = Array::New(len);
for (size_t i = 0; i < len; i++) {
- char val = static_cast<const char*>(buf)[i];
+ unsigned char val = reinterpret_cast<const unsigned char*>(buf)[i];
array->Set(Integer::New(i), Integer::New(val));
}
argv[0] = array;

0 comments on commit ed8c43d

Please sign in to comment.