Browse files

zlib: Emit 'close' on destroy().

  • Loading branch information...
1 parent b48684c commit f4a4ef7a2da34ec9d155f82df0133b40382c53e9 @dominictarr dominictarr committed with isaacs Jul 24, 2012
Showing with 37 additions and 0 deletions.
  1. +1 −0 lib/zlib.js
  2. +36 −0 test/simple/test-zlib-destroy.js
View
1 lib/zlib.js
@@ -455,6 +455,7 @@ Zlib.prototype.destroy = function() {
this.readable = false;
this.writable = false;
this._ended = true;
+ this.emit('close');
};
util.inherits(Deflate, Zlib);
View
36 test/simple/test-zlib-destroy.js
@@ -0,0 +1,36 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common');
+var assert = require('assert');
+var zlib = require('zlib');
+
+['Deflate', 'Inflate', 'Gzip', 'Gunzip', 'DeflateRaw', 'InflateRaw', 'Unzip']
+ .forEach(function (name) {
+ var a = false;
+ var zStream = new zlib[name]();
+ zStream.on('close', function () {
+ a = true;
+ });
+ zStream.destroy();
+
+ assert.equal(a, true, name+'#destroy() must emit \'close\'');
+ });

0 comments on commit f4a4ef7

Please sign in to comment.