Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Aug 31, 2015
  1. @orangemocha

    Update README to reflect move to nodejs/node

    orangemocha committed
    Ref: #25876
    PR-URL: #25897
    Reviewed-By: jasnell - James M Snell <>
    Reviewed-By: bnoordhuis - Ben Noordhuis  <>
Commits on Aug 17, 2015
  1. @orangemocha

    test: add test-spawn-cmd-named-pipe

    orangemocha committed
    See #7345
    Adding a test to verify that a node process spawned via cmd with
    named pipes can access its stdio streams.
    PR-URL: #7433
    Reviewed-By: Fedor Indutny <>
Commits on Aug 6, 2015
  1. @JacksonTian @jasnell

    src: make pass the cpplint

    JacksonTian committed with jasnell
    PR-URL: #25818
    Reviewed-By: James M Snell <>
  2. @darul75 @jasnell


    darul75 committed with jasnell
    PR-URL: #25615
    Reviewed-By: James M Snell <>
    Reviewed-By: Steven R Loomis <>
Commits on Aug 5, 2015
  1. @chad3814 @jasnell

    doc: Change the link for v8 docs to

    chad3814 committed with jasnell
    No offense to @izs, but the doxygen he put up 3.5 years ago isn't
    accurate for node 0.12 nor io.js. I'm trying to keep up and have
    multiple sets of doxygen of v8 available at
    Reviewed-By: James M Snell <>
    PR-URL: #25658
  2. @dyanarose @jasnell

    doc: buffer, adding missing backtick

    dyanarose committed with jasnell
    Reviewed-By: James M Snell <>
    PR-URL: #25767
  3. @daveboivin @jasnell

    Update assert.markdown

    daveboivin committed with jasnell
    The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
    The article "Error Handling in Node.js" by Joyent ( uses the assert module in an efficient way to validate required function arguments.
    Reviewed-By: James M Snell <>
    PR-URL: #25786
Commits on Aug 4, 2015
  1. @radarhere @jasnell

    Fixed typo

    radarhere committed with jasnell
    Reviewed-By: James M Snell <>
    PR-URL: #25805
Commits on Jul 28, 2015
  1. @dnakamura @mhdawson

    udp: Fix potential memory leak in UdpWrap::OnRecv

    dnakamura committed with mhdawson
    Handle case where realloc fails and returns a null ptr
    Reviewed-By: Michael Dawson <>
    PR-URL: #25534
Commits on Jul 27, 2015
  1. @joaocgreis
Commits on Jul 24, 2015
  1. @orangemocha

    test: mark test-signal-unregister as flaky

    orangemocha committed
    This test just failed on Ubuntu in Jenkins, for a change that
    is 100% Windows-specific.
    Reviewed-By: Joao Reis <>
    PR-URL: #25750
Commits on Jul 23, 2015
  1. @joaocgreis

    test: fix test-debug-port-from-cmdline

    joaocgreis committed
    This change is a backport of 2b4b600
    from io.js.
    Original commit message:
      This test was failing because the spawned process was terminated
      before anything could be done, by calling child.stdin.end. With this
      change, the child's stdin is no longer closed. When the stdin is not
      a tty, io.js waits for the whole input before starting, so the child
      must be run with --interactive to process the command sent by the
      parent. The child is killed explicitly by the parent before it exits.
      This test was failing silently because the asserts were not called if
      nothing was received from the child. This fix moves assertOutputLines
      to always run on exit.
      Fixes: nodejs/node#2177
      Refs: nodejs/node#2094
      PR-URL: nodejs/node#2186
      Reviewed-By: Colin Ihrig <>
      Reviewed-By: Rod Vagg <>
      Reviewed-By: Johan Bergström <>
      Reviewed-By: Alexis Campailla <>
    Reviewed-By: Colin Ihrig <>
    PR-URL: #25748
Commits on Jul 22, 2015
  1. @joaocgreis @orangemocha

    win,msi: correct installation path registry keys

    joaocgreis committed with orangemocha
    Since install is per machine only, installation path should be stored
    in local machine instead of current user. The registry stores HKLM in
    different places for 32 and 64 bit applications, so the installer will
    not suggest the old path when upgrading from 32 to 64 bit version.
    Fixes #5592
    Fixes #25087
    PR-URL: #25640
    Reviewed-By: Alexis Campailla <>
    Reviewed-By: Bert Belder <>
  2. @joaocgreis @orangemocha

    win,msi: change InstallScope to perMachine

    joaocgreis committed with orangemocha
    The MSI install scope was set to the WiX default, which is per-user.
    However, with UAC, it could not be installed by a standard user because
    InstallPrivileges is elevated by default, hence the install scope
    should be set to per-machine. Furthermore, the default install path is
    a per-machine location and setting the system path requires
    administrator privileges.
    By changing the InstallScope to perMachine, Start Menu shortcuts are
    placed in ProgramData and not the installing user's AppData folder,
    making the shortcuts available to other users. This also fixes the
    installation when AppData is a network folder.
    The custom action is necessary to allow upgrades. Since a per-machine
    MSI cannot upgrade an application installed per-user, the custom action
    checks if there is going to be an upgrade to a previous version
    installed per-user and sets the installation as per-user to allow
    upgrading. Hence, the advantages of installing per-machine will only
    apply in fresh installations.
    Fixes #5849
    Fixes #7629
    PR-URL: #25640
    Reviewed-By: Alexis Campailla <>
    Reviewed-By: Bert Belder <>
Commits on Jul 20, 2015
  1. @indutny


    indutny committed
    Reviewed-By: Fedor Indutny <>
    PR-URL: #25739
  2. @indutny

    test: add regression test for #25735

    indutny committed
    See: #25736
    Reviewed-By: Fedor Indutny <>
    PR-URL: #25739
  3. @indutny

    tls: do not hang without `newSession` handler

    indutny committed
    When listening for client hello parser events (like OCSP requests), do
    not hang if `newSession` event handler is not present.
    Fix: #8660
    Fix: #25735
    Reviewed-By: Fedor Indutny <>
    PR-URL: #25739
Commits on Jul 17, 2015
  1. @misterdjules

    test: mark http-pipeline-flood flaky on win32

    misterdjules committed
    Reviewed-By: Julien Gilli <>
    PR-URL: #25707
  2. @cgalibern @misterdjules

    configure: add --without-mdb flag

    cgalibern committed with misterdjules
    Add a configuration flag that prevents from being built.
    The default behavior is still the same and is built by default
    on Solaris based platforms such as SmartOS.
    Using --without-mdb fixes build issues on Solaris based platforms where
    libproc.h is not available or not compatible with the one shipped by
    Fixes #6439.
    Reviewed-By: Julien Gilli <>
    PR-URL: #25707
Commits on Jul 16, 2015
  1. @joaocgreis

    test: unmark tests that are no longer flaky

    joaocgreis committed
    - `test-crypto-domains` was fixed by
    - All tests under linux appear to be fixed and have not failed recently
    on Jenkins
    - `test-http-dns-fail` was fixed by the DNS configuration change
    mentioned in nodejs/node-v0.x-archive#8056
    Fixes #25656
    Fixes #25673
    Reviewed-By: Alexis Campailla <>
    PR-URL: #25676
Commits on Jul 10, 2015
  1. @orangemocha

    build: run-ci makefile rule

    orangemocha committed
    Adding a single rule to be called from Jenkins.
    Reviewed-By: Julien Gilli <>
    PR-URL: #25653
  2. @orangemocha

    test: runner should return 0 on flaky tests

    orangemocha committed
    Make the test runner return a 0 exit code when only
    flaky tests fail and --flaky-tests=dontcare is specified.
    Reviewed-By: Julien Gilli <>
    PR-URL: #25653
  3. @orangemocha

    build: support flaky tests in test-ci

    orangemocha committed
    Adding support for specifying flaky test mode to
    the test runner:
    - via an environment variable FLAKY_TESTS for Makefile
    - via an argument ignore-flaky for vcbuild.bat
    Reviewed-By: Julien Gilli <>
    PR-URL: #25653
  4. @orangemocha

    build: support Jenkins via test-ci

    orangemocha committed
    Reviewed-By: Julien Gilli <>
    PR-URL: #25653
  5. @jbergstroem @orangemocha

    tools: pass constant to logger instead of string

    jbergstroem committed with orangemocha
    On a few of our installations (namely CentOS), passing 'INFO'
    resulted in a silent loglevel. Use a logging constant instead.
    Cherry-picked from nodejs/node@8606793
    Original commit metadata follows:
      Fixes: nodejs/build#104
      PR-URL: nodejs/node#1842
      Reviewed-By: Rod Vagg <>
    Reviewed-By: Julien Gilli <>
    PR-URL: #25653
  6. @orangemocha

    test: support writing test output to file

    orangemocha committed
    This is a minimal effort to support test output written both to
    stdout and file in order to get our buildbots understanding
    test output.
    Cherry picked from jbergstroem/node@3194073
    Original commit message follows:
      PR-URL: nodejs/node#934
      Reviewed-By: Chris Dickinson <>
      Reviewed-By: Ben Noordhuis <>
    Reviewed-By: Julien Gilli <>
    PR-URL: #25653
  7. @jasnell

    doc: additional refinement to readable event

    jasnell committed
    Per #25635 (comment)
    Additional refinement to the clarification on the `readable` event
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  8. @jasnell

    doc: readable event clarification

    jasnell committed
    per #14597
    Indicate that `'readable'` indicates only that data can
    be read from the stream, not that there is actually data
    to be consumed. `[size])` can still return
    null. Includes an example that illustrates the point.
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  9. @jasnell

    doc: stream.unshift does not reset reading state

    jasnell committed
    Per #14604,
    Document that performing an `unshift` during a read
    can have unexpected results. Following the `unshift`
    with a `push('')` resets the reading state appropriately.
    Also indicate that doing an `unshift` during a read
    is not optimal and should be avoided.
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  10. @danielrentz @jasnell

    Update util.markdown

    danielrentz committed with jasnell
    Fix for #25559 (Typo in example of util.deprecate() documentation)
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  11. @fresheneesz @jasnell

    doc: clarify Readable._read and Readable.push

    fresheneesz committed with jasnell
    Minor clarifications around Readable._read and Readable.push
    to make their implementation/usage easier to understand.
    #14124 (comment)
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  12. @jasnell

    doc: two minor stream doc improvements

    jasnell committed
    per: #14596
    1. document that a runtime error will occur if you attempt
       to unshift after the end event
    2. document that calling read after the end event will return
       null and will not trigger a runtime error
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  13. @bsteephenson @jasnell

    docs:events clarify emitter.listener() behavior

    bsteephenson committed with jasnell
    Clarifies that emitter.listener() returns a copy, not a reference
    Resolves issue #9022
    Reviewed-By: James M Snell <>
    PR-URL: #25635
  14. @misterdjules

    Merge remote-tracking branch 'upstream/v0.12'

    misterdjules committed
Commits on Jul 9, 2015
  1. @misterdjules

    Now working on 0.12.8

    misterdjules committed
Something went wrong with that request. Please try again.